diff options
| author | AJ Heller <hork@google.com> | 2024-03-07 10:52:19 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-03-07 10:52:19 -0800 |
| commit | 6caea36a426613989dab3e997dc94fe72fc7fa28 (patch) | |
| tree | 59c51401d941854ea4e40e560f730c3f13e6c64a | |
| parent | e5ae3b6b44bf3b64d24bfb4b4f82556239b986db (diff) | |
| download | grpc-grpc-6caea36a426613989dab3e997dc94fe72fc7fa28.tar.gz | |
[EventEngine] rm invalid assert (#35953) (#36069)
Backports https://github.com/grpc/grpc/pull/35953 to v1.60.x
----
In the case where the timer delay is <= 0, RunAfter will return an
invalid handle since the callback will not be cancellable. The asserting
is invalid in this case. Based on how this handle is used, it seems
there is no need for a check that the handle is set. It would only
matter if `finish_bdp_ping` were called again before
`next_bdp_ping_timer_expired` were called, which I don't think is
possible.
| -rw-r--r-- | src/core/ext/transport/chttp2/transport/chttp2_transport.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/core/ext/transport/chttp2/transport/chttp2_transport.cc b/src/core/ext/transport/chttp2/transport/chttp2_transport.cc index a1e52fab67..226ebcf7ad 100644 --- a/src/core/ext/transport/chttp2/transport/chttp2_transport.cc +++ b/src/core/ext/transport/chttp2/transport/chttp2_transport.cc @@ -2975,7 +2975,6 @@ static void next_bdp_ping_timer_expired_locked( grpc_core::RefCountedPtr<grpc_chttp2_transport> t, GRPC_UNUSED grpc_error_handle error) { GPR_DEBUG_ASSERT(error.ok()); - GPR_ASSERT(t->next_bdp_ping_timer_handle != TaskHandle::kInvalid); t->next_bdp_ping_timer_handle = TaskHandle::kInvalid; if (t->flow_control.bdp_estimator()->accumulator() == 0) { // Block the bdp ping till we receive more data. |