aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authoraiuto <aiuto@google.com>2023-09-01 16:34:58 -0400
committerGitHub <noreply@github.com>2023-09-01 13:34:58 -0700
commit50de9aadb256a12968a46b9dea77e812d1d2f103 (patch)
tree1061095f524d27b20132541d74778552bd014af9
parentac79b742c4371bf90121cb2b3aa5e86c28590dac (diff)
downloadrules_pkg-50de9aadb256a12968a46b9dea77e812d1d2f103.tar.gz
buildifier lint fixes (#744)
-rw-r--r--pkg/mappings.bzl6
1 files changed, 6 insertions, 0 deletions
diff --git a/pkg/mappings.bzl b/pkg/mappings.bzl
index 0901b92..3a7ddbb 100644
--- a/pkg/mappings.bzl
+++ b/pkg/mappings.bzl
@@ -123,9 +123,11 @@ def pkg_attributes(
ret["gid"] = gid
if user != None and user.isdigit() and uid == None:
+ # buildifier: disable=print
print("Warning: found numeric username and no uid, did you mean to specify the uid instead?")
if group != None and group.isdigit() and gid == None:
+ # buildifier: disable=print
print("Warning: found numeric group and no gid, did you mean to specify the gid instead?")
return json.encode(ret)
@@ -304,6 +306,7 @@ def _pkg_files_impl(ctx):
have_it = src_dest_paths_map.get(rf)
if have_it:
if have_it != dest_path:
+ # buildifier: disable=print
print("same source mapped to different locations", rf, have_it, dest_path)
else:
src_dest_paths_map[rf] = dest_path
@@ -593,9 +596,12 @@ pkg_mklink_impl = rule(
provides = [PackageSymlinkInfo],
)
+#buildifier: disable=function-docstring-args
def pkg_mklink(name, link_name, target, attributes = None, src = None, **kwargs):
"""Create a symlink.
+ @wraps(pkg_mklink_impl)
+
Args:
name: target name
target: target path that the link should point to.