diff options
| author | Jiyong Park <jiyong@google.com> | 2021-01-20 17:54:24 +0900 |
|---|---|---|
| committer | Jiyong Park <jiyong@google.com> | 2021-01-27 08:04:31 +0000 |
| commit | b436e7f587f00dedd1fd7235699b0df648628332 (patch) | |
| tree | ffce30747f7359305ab6ecf585b94204dda3da04 | |
| parent | a347d57a2f69026442dfcb0a0a2f7dccda740232 (diff) | |
| download | manifest-b436e7f587f00dedd1fd7235699b0df648628332.tar.gz | |
Add toolpath of aidl-format to GLOBAL_PRESUBMIT.cfg
... so that we can use `aidl_format = true` in project-specific
PREUPLOAD.cfg files.
Bug: 144540481
Test: Add `aidl_format = true` to /system/tools/aidl/REUPLOAD.cfg,
make a poorly formatted change in one of the AIDL file in the repo.
Creating a commit and executing `repo upload` caught it and did an
automatic fixup.
[FAILED] aidl_format
FILES: ('tests/android/aidl/tests/ITestService.aidl',) 17,18d16
...
[RUNNING 5/5] aidl_format
An automatic fix can be attempted for the "aidl_format" hook. Do you
want to run it? (Yes/no)? yes
Fix successfully applied. Amend the current commit before attempting to
upload again.
[FAILED] repohooks for platform/system/tools/aidl failed in 10.274s
FATAL: Preupload failed due to above error(s).
Change-Id: Ib1681f18f879d6a5611e0b013f699ef7ccc5a1f2
| -rw-r--r-- | GLOBAL-PREUPLOAD.cfg | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/GLOBAL-PREUPLOAD.cfg b/GLOBAL-PREUPLOAD.cfg index 89eb6c799..09ad7903e 100644 --- a/GLOBAL-PREUPLOAD.cfg +++ b/GLOBAL-PREUPLOAD.cfg @@ -18,3 +18,4 @@ google-java-format = ${REPO_ROOT}/prebuilts/tools/common/google-java-format/goog google-java-format-diff = ${REPO_ROOT}/prebuilts/tools/common/google-java-format/google-java-format-diff.py rustfmt = ${REPO_ROOT}/prebuilts/rust/${BUILD_OS}/stable/rustfmt cpplint = ${REPO_ROOT}/external/google-styleguide/cpplint/cpplint.py +aidl-format = ${REPO_ROOT}/system/tools/aidl/aidl-format.sh |