diff options
author | JP Abgrall <jpa@google.com> | 2013-04-08 15:09:26 -0700 |
---|---|---|
committer | Amit Pundir <amit.pundir@linaro.org> | 2018-08-30 21:40:42 +0530 |
commit | bc1e31b839950c44ad45ed225f1b7e51874b9fb2 (patch) | |
tree | 6ca7539549f5fb6a4a7b67d7036545176f67bbaf | |
parent | 11a32dfd170ba26f4f3329b0881a4ff239d3379e (diff) | |
download | linaro-android-bc1e31b839950c44ad45ed225f1b7e51874b9fb2.tar.gz |
ANDROID: netfilter: xt_qtaguid: rate limit some of the printks
Some of the printks are in the packet handling path.
We now ratelimit the very unlikely errors to avoid
kmsg spamming.
Signed-off-by: JP Abgrall <jpa@google.com>
-rw-r--r-- | net/netfilter/xt_qtaguid.c | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/net/netfilter/xt_qtaguid.c b/net/netfilter/xt_qtaguid.c index 992a6e044902..4ec6d23876c5 100644 --- a/net/netfilter/xt_qtaguid.c +++ b/net/netfilter/xt_qtaguid.c @@ -19,6 +19,7 @@ #include <linux/module.h> #include <linux/netfilter/x_tables.h> #include <linux/netfilter/xt_qtaguid.h> +#include <linux/ratelimit.h> #include <linux/skbuff.h> #include <linux/workqueue.h> #include <net/addrconf.h> @@ -1328,12 +1329,12 @@ static void iface_stat_update_from_skb(const struct sk_buff *skb, } if (unlikely(!el_dev)) { - pr_err("qtaguid[%d]: %s(): no par->in/out?!!\n", - par->hooknum, __func__); + pr_err_ratelimited("qtaguid[%d]: %s(): no par->in/out?!!\n", + par->hooknum, __func__); BUG(); } else if (unlikely(!el_dev->name)) { - pr_err("qtaguid[%d]: %s(): no dev->name?!!\n", - par->hooknum, __func__); + pr_err_ratelimited("qtaguid[%d]: %s(): no dev->name?!!\n", + par->hooknum, __func__); BUG(); } else { proto = ipx_proto(skb, par); @@ -1416,8 +1417,8 @@ static void if_tag_stat_update(const char *ifname, uid_t uid, iface_entry = get_iface_entry(ifname); if (!iface_entry) { - pr_err("qtaguid: iface_stat: stat_update() %s not found\n", - ifname); + pr_err_ratelimited("qtaguid: iface_stat: stat_update() " + "%s not found\n", ifname); return; } /* It is ok to process data when an iface_entry is inactive */ |