aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKen Chen <cken@google.com>2020-08-30 05:07:23 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2020-08-30 05:07:23 +0000
commit2c2546b158ec41ea68fda23c884c04b13f98ce44 (patch)
tree7b32444c5e36195e1474d3def71189746c0c0720
parent358c8c95725380eafe9f2aed0a4e2542592e85ff (diff)
parentc5ea7569a80468665fd80ff3f987dd5ca5d2e7e1 (diff)
downloadbionic-2c2546b158ec41ea68fda23c884c04b13f98ce44.tar.gz
Fix OOB read in DNS resolver am: 43264bc365 am: c5ea7569a8
Original change: https://googleplex-android-review.googlesource.com/c/platform/bionic/+/12329970 Change-Id: I5a3ea0eb929c76e76be9a17264b7f1b6b04e9f8c
-rw-r--r--libc/dns/resolv/res_send.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/libc/dns/resolv/res_send.c b/libc/dns/resolv/res_send.c
index a645a6b4a..fa81e6dc5 100644
--- a/libc/dns/resolv/res_send.c
+++ b/libc/dns/resolv/res_send.c
@@ -948,6 +948,8 @@ send_vc(res_state statp, struct __res_params* params,
else
break;
}
+ // return size should never exceed container size
+ resplen = anssiz;
}
/*
* If the calling applicating has bailed out of
@@ -960,7 +962,7 @@ send_vc(res_state statp, struct __res_params* params,
DprintQ((statp->options & RES_DEBUG) ||
(statp->pfcode & RES_PRF_REPLY),
(stdout, ";; old answer (unexpected):\n"),
- ans, (resplen > anssiz) ? anssiz: resplen);
+ ans, resplen);
goto read_len;
}