diff options
author | Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> | 2022-04-27 18:33:42 +0000 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2022-04-27 18:33:42 +0000 |
commit | ede618aef2e66825d484503c020c106953db7e97 (patch) | |
tree | 57697275c2f2413abd159c6089436795490e8099 | |
parent | 9ef57feced679356284a3a309424ecdc036c25fa (diff) | |
parent | 6c64caef7e1230606ffe03ce401c8c7c909b6a67 (diff) | |
download | bionic-ede618aef2e66825d484503c020c106953db7e97.tar.gz |
Merge "Merge "Fix unistd.exec_argv0_null for new kernels." into android10-tests-dev am: 16457fd9d0" into android11-tests-dev
-rw-r--r-- | tests/unistd_test.cpp | 14 |
1 files changed, 12 insertions, 2 deletions
diff --git a/tests/unistd_test.cpp b/tests/unistd_test.cpp index 6b2856169..23bd35aa2 100644 --- a/tests/unistd_test.cpp +++ b/tests/unistd_test.cpp @@ -1500,11 +1500,21 @@ TEST(UNISTD_TEST, execvp_libcore_test_55017) { } TEST(UNISTD_TEST, exec_argv0_null) { - // http://b/33276926 + // http://b/33276926 and http://b/227498625. + // + // With old kernels, bionic will see the null pointer and use "<unknown>" but + // with new (5.18+) kernels, the kernel will already have substituted the + // empty string, so we don't make any assertion here about what (if anything) + // comes before the first ':'. + // + // If this ever causes trouble, we could change bionic to replace _either_ the + // null pointer or the empty string. We could also use the actual name from + // readlink() on /proc/self/exe if we ever had reason to disallow programs + // from trying to hide like this. char* args[] = {nullptr}; char* envs[] = {nullptr}; ASSERT_EXIT(execve("/system/bin/run-as", args, envs), testing::ExitedWithCode(1), - "<unknown>: usage: run-as"); + ": usage: run-as"); } TEST(UNISTD_TEST, fexecve_failure) { |