diff options
| author | Hajime Morrita <morrita@google.com> | 2021-07-29 15:19:52 -0700 |
|---|---|---|
| committer | Hajime Morrita <morrita@google.com> | 2021-07-29 15:46:27 -0700 |
| commit | ea331d6bcc07576921a1cb5a188214df4212eb99 (patch) | |
| tree | 696ebdd937b832edafc1284e6dc0236e65394186 | |
| parent | 523de300dda61b204b855b3aad5489c8be464720 (diff) | |
| download | build-ea331d6bcc07576921a1cb5a188214df4212eb99.tar.gz | |
Drop pinner.pin_camera=false from the default prop.
The pin_camera flag being false makes some in-market devices
(redfin, bramble, coral, etc.) not pin the camera app by default.
Although a Phenotype flag overrides this value,
the OTA flag delivery can fail and ends up non-ping state.
This change makes sure that the device pins the camera app by default
by removing pinner.pin_camera properties modification from this file.
The current default is to pin the camera. See PinnerServices.java
Note that the camera pinning is still disabled on crosshatch family,
sicne it is known to be prone to the memory shortage.
See device-crosshatch.mk.
Also note that some newer devices already pin by default because
they don't refer this file, although the name implies it might.
Test: On Redfin:
$ vendor/google/tools/flashall -w
$ adb root && adb wait-for-device && adb shell am start -a com.android.setupwizard.FOUR_CORNER_EXIT
$ adb shell dumpsys pinner
Bug: 195035033
Bug: 184897981
Change-Id: I81207d0527f758d4800319a3a3c323919daaf814
| -rw-r--r-- | target/product/iorap_large_memory_config.mk | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/target/product/iorap_large_memory_config.mk b/target/product/iorap_large_memory_config.mk index 9aa664214d..0c6c89af93 100644 --- a/target/product/iorap_large_memory_config.mk +++ b/target/product/iorap_large_memory_config.mk @@ -12,7 +12,3 @@ # See the License for the specific language governing permissions and # limitations under the License. # - -# Disable Camera pinner by default -PRODUCT_PRODUCT_PROPERTIES += \ - pinner.pin_camera=false |