diff options
author | TreeHugger Robot <treehugger-gerrit@google.com> | 2022-07-19 02:02:53 +0000 |
---|---|---|
committer | Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> | 2022-07-19 02:02:53 +0000 |
commit | 72e71c9b90510f5c124c32a052c4e4cf3ba89a4c (patch) | |
tree | 16083c74e4a0ef0b1e624c99fd8ed6e1275b78c1 | |
parent | b80fcf0fbdddee4845a245cb4d6ffdf5e6a2edb7 (diff) | |
parent | 9c24f649c7efb3abce3076abb1a90bb0364a0c38 (diff) | |
download | cts-72e71c9b90510f5c124c32a052c4e4cf3ba89a4c.tar.gz |
Merge "ITS: use vendor_api_level to gate new test on existing features" into stage-aosp-tm-ts-dev am: 0167f11976 am: 9c24f649c7
Original change: https://googleplex-android-review.googlesource.com/c/platform/cts/+/19326834
Change-Id: I1dc84fffaa00ed445eb38f9d9384ff0d378ba9c3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
4 files changed, 19 insertions, 7 deletions
diff --git a/apps/CameraITS/tests/scene2_a/test_auto_flash.py b/apps/CameraITS/tests/scene2_a/test_auto_flash.py index b20da2dbc54..c00cd5c358c 100644 --- a/apps/CameraITS/tests/scene2_a/test_auto_flash.py +++ b/apps/CameraITS/tests/scene2_a/test_auto_flash.py @@ -107,10 +107,10 @@ class AutoFlashTest(its_base_test.ItsBaseTest): test_name = os.path.join(self.log_path, _TEST_NAME) # check SKIP conditions - first_api_level = its_session_utils.get_first_api_level(self.dut.serial) + vendor_api_level = its_session_utils.get_vendor_api_level(self.dut.serial) camera_properties_utils.skip_unless( camera_properties_utils.flash(props) and - first_api_level >= its_session_utils.ANDROID13_API_LEVEL) + vendor_api_level >= its_session_utils.ANDROID13_API_LEVEL) # establish connection with lighting controller arduino_serial_port = lighting_control_utils.lighting_control( diff --git a/apps/CameraITS/tests/scene4/test_video_aspect_ratio_and_crop.py b/apps/CameraITS/tests/scene4/test_video_aspect_ratio_and_crop.py index 8562ba474cf..bb713672e00 100644 --- a/apps/CameraITS/tests/scene4/test_video_aspect_ratio_and_crop.py +++ b/apps/CameraITS/tests/scene4/test_video_aspect_ratio_and_crop.py @@ -137,9 +137,9 @@ class VideoAspectRatioAndCropTest(its_base_test.ItsBaseTest): logging.debug('physical available focal lengths: %s', str(fls_physical)) # Check SKIP conditions. - first_api_level = its_session_utils.get_first_api_level(self.dut.serial) + vendor_api_level = its_session_utils.get_vendor_api_level(self.dut.serial) camera_properties_utils.skip_unless( - first_api_level >= its_session_utils.ANDROID13_API_LEVEL) + vendor_api_level >= its_session_utils.ANDROID13_API_LEVEL) # Load scene. its_session_utils.load_scene(cam, props, self.scene, diff --git a/apps/CameraITS/tests/sensor_fusion/test_video_stabilization.py b/apps/CameraITS/tests/sensor_fusion/test_video_stabilization.py index 0be38b56d11..195d5670eba 100644 --- a/apps/CameraITS/tests/sensor_fusion/test_video_stabilization.py +++ b/apps/CameraITS/tests/sensor_fusion/test_video_stabilization.py @@ -129,7 +129,7 @@ class VideoStabilizationTest(its_base_test.ItsBaseTest): in gyroscope movement. Test is a PASS if rotation is reduced in video. """ - def test_video_stability(self): + def test_video_stabilization(self): rot_rig = {} log_path = self.log_path @@ -139,12 +139,12 @@ class VideoStabilizationTest(its_base_test.ItsBaseTest): hidden_physical_id=self.hidden_physical_id) as cam: props = cam.get_camera_properties() props = cam.override_with_hidden_physical_camera_props(props) - first_api_level = its_session_utils.get_first_api_level(self.dut.serial) + vendor_api_level = its_session_utils.get_vendor_api_level(self.dut.serial) supported_stabilization_modes = props[ 'android.control.availableVideoStabilizationModes'] camera_properties_utils.skip_unless( - first_api_level >= its_session_utils.ANDROID13_API_LEVEL and + vendor_api_level >= its_session_utils.ANDROID13_API_LEVEL and _VIDEO_STABILIZATION_MODE in supported_stabilization_modes) # Raise error if not FRONT or REAR facing camera diff --git a/apps/CameraITS/utils/its_session_utils.py b/apps/CameraITS/utils/its_session_utils.py index e91565e250f..c2065ba6ac4 100644 --- a/apps/CameraITS/utils/its_session_utils.py +++ b/apps/CameraITS/utils/its_session_utils.py @@ -1612,6 +1612,18 @@ def get_first_api_level(device_id): return first_api_level +def get_vendor_api_level(device_id): + """Return the int value for the vendor API level of the device.""" + cmd = 'adb -s %s shell getprop ro.vendor.api_level' % device_id + try: + vendor_api_level = int(subprocess.check_output(cmd.split()).rstrip()) + logging.debug('First vendor API level: %d', vendor_api_level) + except (subprocess.CalledProcessError, ValueError): + logging.error('No vendor_api_level. Setting to build version.') + vendor_api_level = get_build_sdk_version(device_id) + return vendor_api_level + + class ItsSessionUtilsTests(unittest.TestCase): """Run a suite of unit tests on this module.""" |