summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAaqib Ismail <aaqibismail@google.com>2023-12-05 01:33:21 +0000
committerGerrit Code Review <noreply-gerritcodereview@google.com>2023-12-05 01:33:21 +0000
commit86a35e142782ca3db7fd3baa146dbb2b9187dabd (patch)
tree881b6db0ef6ba4405b23817d3bfa04245f93158d
parent80e3cd4ccdf70f757e95cb0b40e8dec141f60b1d (diff)
parent170de655b1163232527a6591277895c9907f17fc (diff)
downloadcts-86a35e142782ca3db7fd3baa146dbb2b9187dabd.tar.gz
Merge "Fix missing rounding and incorrect float to int conversions" into android14-tests-dev
-rw-r--r--tests/tests/car/src/android/car/cts/utils/VehiclePropertyVerifier.java20
1 files changed, 10 insertions, 10 deletions
diff --git a/tests/tests/car/src/android/car/cts/utils/VehiclePropertyVerifier.java b/tests/tests/car/src/android/car/cts/utils/VehiclePropertyVerifier.java
index 20a1c69ecd8..5bea216ef0c 100644
--- a/tests/tests/car/src/android/car/cts/utils/VehiclePropertyVerifier.java
+++ b/tests/tests/car/src/android/car/cts/utils/VehiclePropertyVerifier.java
@@ -1678,25 +1678,25 @@ public class VehiclePropertyVerifier<T> {
verifyHvacTemperatureIsValid(suggestedTempInFahrenheit, minTempInFahrenheitTimesTen,
maxTempInFahrenheitTimesTen, incrementInFahrenheitTimesTen);
- int suggestedTempInCelsiusTimesTen = suggestedTempInCelsius.intValue() * 10;
- int suggestedTempInFahrenheitTimesTen = suggestedTempInFahrenheit.intValue() * 10;
+ int suggestedTempInCelsiusTimesTen = (int) (suggestedTempInCelsius * 10f);
+ int suggestedTempInFahrenheitTimesTen = (int) (suggestedTempInFahrenheit * 10f);
int numIncrementsCelsius =
- (suggestedTempInCelsiusTimesTen - minTempInCelsiusTimesTen)
- / incrementInCelsiusTimesTen;
+ Math.round((suggestedTempInCelsiusTimesTen - minTempInCelsiusTimesTen)
+ / incrementInCelsiusTimesTen.floatValue());
int numIncrementsFahrenheit =
- (suggestedTempInFahrenheitTimesTen - minTempInFahrenheitTimesTen)
- / incrementInFahrenheitTimesTen;
+ Math.round((suggestedTempInFahrenheitTimesTen - minTempInFahrenheitTimesTen)
+ / incrementInFahrenheitTimesTen.floatValue());
assertWithMessage(
- "The temperature in Celsius must be equivalent to the temperature in"
- + " Fahrenheit.")
+ "The temperature in celsius must map to the same temperature in fahrenheit"
+ + " using the HVAC_TEMPERATURE_SET config array: "
+ + hvacTemperatureSetConfigArray)
.that(numIncrementsFahrenheit)
.isEqualTo(numIncrementsCelsius);
}
public static void verifyHvacTemperatureIsValid(float temp, int minTempTimesTen,
int maxTempTimesTen, int incrementTimesTen) {
- Float tempMultiplied = temp * 10.0f;
- int intTempTimesTen = tempMultiplied.intValue();
+ int intTempTimesTen = (int) (temp * 10f);
assertWithMessage(
"The temperature value " + intTempTimesTen + " must be at least "
+ minTempTimesTen + " and at most " + maxTempTimesTen)