diff options
| author | Torne (Richard Coles) <torne@google.com> | 2020-06-11 12:15:21 -0400 |
|---|---|---|
| committer | Torne (Richard Coles) <torne@google.com> | 2020-06-15 15:50:10 -0400 |
| commit | 760c2c351c254e9cca7998f6c99b0533d444ab7f (patch) | |
| tree | 1b26e4deade92493a3b654bc24402d5ad900ed19 | |
| parent | d3b14b12868800af7ecc5824c949fa5c440d34f0 (diff) | |
| download | cts-760c2c351c254e9cca7998f6c99b0533d444ab7f.tar.gz | |
Don't test for AppCache callbacks.
Remove the code in WebSettingsTest#testAppCacheEnabled which asserts
that AppCachee callbacks actually happen; the implementation of AppCache
in Chromium is going to be removed in future so it won't be possible for
this test to pass beyond that point.
Bug: 156266477
Test: atest WebSettingsTest#testAppCacheEnabled
Merged-In: Iff215f060387eb5cfd798caa56dcd02ea1e9d7af
Change-Id: Iff215f060387eb5cfd798caa56dcd02ea1e9d7af
| -rw-r--r-- | tests/tests/webkit/src/android/webkit/cts/WebSettingsTest.java | 15 |
1 files changed, 4 insertions, 11 deletions
diff --git a/tests/tests/webkit/src/android/webkit/cts/WebSettingsTest.java b/tests/tests/webkit/src/android/webkit/cts/WebSettingsTest.java index d004565980a..ecfd2ec13b7 100644 --- a/tests/tests/webkit/src/android/webkit/cts/WebSettingsTest.java +++ b/tests/tests/webkit/src/android/webkit/cts/WebSettingsTest.java @@ -739,17 +739,10 @@ public class WebSettingsTest extends ActivityInstrumentationTestCase2<WebViewCts Thread.sleep(1000); assertEquals("Loaded", mOnUiThread.getTitle()); - // Test that when AppCache is enabled and a valid path is provided, we - // get an AppCache callback of some kind. - mSettings.setAppCachePath(getActivity().getDir("appcache", 0).getPath()); - mOnUiThread.loadUrlAndWaitForCompletion(url); - new PollingCheck(WEBVIEW_TIMEOUT) { - @Override - protected boolean check() { - return mOnUiThread.getTitle() != null - && mOnUiThread.getTitle().endsWith("Callback"); - } - }.run(); + // We used to test that when AppCache is enabled and a valid path is + // provided, we got an AppCache callback of some kind, but AppCache is + // deprecated on the web and will be removed from Chromium in the + // future, so this test has been removed. } // Ideally, we need a test case for the enabled case. However, it seems that |