diff options
author | TreeHugger Robot <treehugger-gerrit@google.com> | 2020-01-09 13:25:46 +0000 |
---|---|---|
committer | Android (Google) Code Review <android-gerrit@google.com> | 2020-01-09 13:25:46 +0000 |
commit | 5e0b06987666bdb15620184726bb332e186d85c1 (patch) | |
tree | 1ce81822d0a8bf11cc9c9a019c4abbd4f125b497 | |
parent | e422bc0c8f77677c82dc979b0f58708d1c997be9 (diff) | |
parent | 305946b910a9ab3974daa4277f155614a3fc27a4 (diff) | |
download | base-5e0b06987666bdb15620184726bb332e186d85c1.tar.gz |
Merge "Fix security problem on PermissionMonitor#hasPermission" into oc-dev
-rw-r--r-- | services/core/java/com/android/server/connectivity/PermissionMonitor.java | 17 |
1 files changed, 9 insertions, 8 deletions
diff --git a/services/core/java/com/android/server/connectivity/PermissionMonitor.java b/services/core/java/com/android/server/connectivity/PermissionMonitor.java index e084ff827c09..57dbfd1e15bf 100644 --- a/services/core/java/com/android/server/connectivity/PermissionMonitor.java +++ b/services/core/java/com/android/server/connectivity/PermissionMonitor.java @@ -21,6 +21,7 @@ import static android.Manifest.permission.CONNECTIVITY_INTERNAL; import static android.Manifest.permission.CONNECTIVITY_USE_RESTRICTED_NETWORKS; import static android.content.pm.ApplicationInfo.FLAG_SYSTEM; import static android.content.pm.ApplicationInfo.FLAG_UPDATED_SYSTEM_APP; +import static android.content.pm.PackageInfo.REQUESTED_PERMISSION_GRANTED; import static android.content.pm.PackageManager.GET_PERMISSIONS; import android.content.BroadcastReceiver; @@ -39,6 +40,8 @@ import android.os.UserManager; import android.text.TextUtils; import android.util.Log; +import com.android.internal.util.ArrayUtils; + import java.util.ArrayList; import java.util.HashMap; import java.util.HashSet; @@ -150,15 +153,13 @@ public class PermissionMonitor { update(mUsers, mApps, true); } - private boolean hasPermission(PackageInfo app, String permission) { - if (app.requestedPermissions != null) { - for (String p : app.requestedPermissions) { - if (permission.equals(p)) { - return true; - } - } + private boolean hasPermission(final PackageInfo app, final String permission) { + if (app.requestedPermissions == null || app.requestedPermissionsFlags == null) { + return false; } - return false; + final int index = ArrayUtils.indexOf(app.requestedPermissions, permission); + if (index < 0 || index >= app.requestedPermissionsFlags.length) return false; + return (app.requestedPermissionsFlags[index] & REQUESTED_PERMISSION_GRANTED) != 0; } private boolean hasNetworkPermission(PackageInfo app) { |