diff options
author | Joe Bolinger <jbolinger@google.com> | 2021-08-14 03:30:22 +0000 |
---|---|---|
committer | Android (Google) Code Review <android-gerrit@google.com> | 2021-08-14 03:30:22 +0000 |
commit | 922fe0da54a504bf97ceacf9ea434cb52c4f522c (patch) | |
tree | 954e231cda7118ac34b3e5030600693097c40e50 | |
parent | 0fa71fccb5303282b76e897f3ed957470904ce5c (diff) | |
parent | 5d5d9eb8122b33705a864a1946da479af2bd10db (diff) | |
download | base-922fe0da54a504bf97ceacf9ea434cb52c4f522c.tar.gz |
Merge "Add a generic error message for missing vendor error strings." into sc-dev
-rw-r--r-- | core/java/android/hardware/face/FaceManager.java | 5 | ||||
-rw-r--r-- | core/java/android/hardware/fingerprint/FingerprintManager.java | 7 |
2 files changed, 11 insertions, 1 deletions
diff --git a/core/java/android/hardware/face/FaceManager.java b/core/java/android/hardware/face/FaceManager.java index 3c3ba595f3fb..385ad2d3577f 100644 --- a/core/java/android/hardware/face/FaceManager.java +++ b/core/java/android/hardware/face/FaceManager.java @@ -790,6 +790,11 @@ public class FaceManager implements BiometricAuthenticator, BiometricFaceConstan } } } + + // This is used as a last resort in case a vendor string is missing + // It should not happen for anything other than FACE_ERROR_VENDOR, but + // warn and use the default if all else fails. + // TODO(b/196639965): update string Slog.w(TAG, "Invalid error message: " + errMsg + ", " + vendorCode); return ""; } diff --git a/core/java/android/hardware/fingerprint/FingerprintManager.java b/core/java/android/hardware/fingerprint/FingerprintManager.java index dc1a50fa6616..87d45b9de745 100644 --- a/core/java/android/hardware/fingerprint/FingerprintManager.java +++ b/core/java/android/hardware/fingerprint/FingerprintManager.java @@ -1386,8 +1386,13 @@ public class FingerprintManager implements BiometricAuthenticator, BiometricFing } } } + + // This is used as a last resort in case a vendor string is missing + // It should not happen for anything other than FINGERPRINT_ERROR_VENDOR, but + // warn and use the default if all else fails. + // TODO(b/196639965): update string Slog.w(TAG, "Invalid error message: " + errMsg + ", " + vendorCode); - return null; + return ""; } /** |