summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKenny Root <kroot@google.com>2013-02-04 15:49:11 -0800
committerKenny Root <kroot@google.com>2013-02-04 15:50:58 -0800
commite66769ad5194cb4533d1087416a2e804ac384285 (patch)
tree22123fc2bb1210baa71e79671e44f7a4aad1daf1
parent5a720bb9b031d44e593d2054bda586ccc3752aa4 (diff)
downloadbase-e66769ad5194cb4533d1087416a2e804ac384285.tar.gz
AndroidKeyStore: return error code on error
Instead of blindly multiplying return value by 1000 to convert to milliseconds, check to see if it's an error condition first. Change-Id: I8eab1e7a86d78c13458fcbbc79d590e452fc9791
-rw-r--r--keystore/java/android/security/KeyStore.java7
1 files changed, 6 insertions, 1 deletions
diff --git a/keystore/java/android/security/KeyStore.java b/keystore/java/android/security/KeyStore.java
index 444dc1d41b1c..ceaff37f3c59 100644
--- a/keystore/java/android/security/KeyStore.java
+++ b/keystore/java/android/security/KeyStore.java
@@ -243,7 +243,12 @@ public class KeyStore {
*/
public long getmtime(String key) {
try {
- return mBinder.getmtime(key) * 1000L;
+ final long millis = mBinder.getmtime(key);
+ if (millis == -1L) {
+ return -1L;
+ }
+
+ return millis * 1000L;
} catch (RemoteException e) {
Log.w(TAG, "Cannot connect to keystore", e);
return -1L;