diff options
author | Tobias Thierer <tobiast@google.com> | 2016-06-01 20:51:45 +0100 |
---|---|---|
committer | Tobias Thierer <tobiast@google.com> | 2016-06-29 17:41:32 +0100 |
commit | 851d806dbd153955f5f4376a3e16da266b3a864f (patch) | |
tree | 349c400a6c1b960ac8e2d38adde0784b90c97a7b | |
parent | f388075f8f8ceac73e6254c4ef273f43e7d346aa (diff) | |
download | base-851d806dbd153955f5f4376a3e16da266b3a864f.tar.gz |
Changes for upgrade to OkHttp 2.7.5
- Use com.android.okhttp.Dns in place of com.android.okhttp.internal.Network
- Specify TimeUnit.MILLISECONDS for timeouts which 2.7.5 allows and
brings us closer to 3+
Change-Id: I95b5d72a94ebe1389f7c2e8d95903aa1aadd944b
-rw-r--r-- | core/java/android/net/Network.java | 23 |
1 files changed, 13 insertions, 10 deletions
diff --git a/core/java/android/net/Network.java b/core/java/android/net/Network.java index fe6932037395..0c0872a78f74 100644 --- a/core/java/android/net/Network.java +++ b/core/java/android/net/Network.java @@ -34,9 +34,13 @@ import java.net.SocketException; import java.net.UnknownHostException; import java.net.URL; import java.net.URLConnection; +import java.util.Arrays; +import java.util.List; +import java.util.concurrent.TimeUnit; import javax.net.SocketFactory; import com.android.okhttp.ConnectionPool; +import com.android.okhttp.Dns; import com.android.okhttp.HttpHandler; import com.android.okhttp.HttpsHandler; import com.android.okhttp.OkHttpClient; @@ -62,10 +66,10 @@ public class Network implements Parcelable { // Objects used to perform per-network operations such as getSocketFactory // and openConnection, and a lock to protect access to them. private volatile NetworkBoundSocketFactory mNetworkBoundSocketFactory = null; - // mLock should be used to control write access to mConnectionPool and mNetwork. + // mLock should be used to control write access to mConnectionPool and mDns. // maybeInitHttpClient() must be called prior to reading either variable. private volatile ConnectionPool mConnectionPool = null; - private volatile com.android.okhttp.internal.Network mNetwork = null; + private volatile Dns mDns = null; private final Object mLock = new Object(); // Default connection pool values. These are evaluated at startup, just @@ -219,17 +223,17 @@ public class Network implements Parcelable { // out) ConnectionPools. private void maybeInitHttpClient() { synchronized (mLock) { - if (mNetwork == null) { - mNetwork = new com.android.okhttp.internal.Network() { + if (mDns == null) { + mDns = new Dns() { @Override - public InetAddress[] resolveInetAddresses(String host) throws UnknownHostException { - return Network.this.getAllByName(host); + public List<InetAddress> lookup(String hostname) throws UnknownHostException { + return Arrays.asList(Network.this.getAllByName(hostname)); } }; } if (mConnectionPool == null) { mConnectionPool = new ConnectionPool(httpMaxConnections, - httpKeepAliveDurationMs); + httpKeepAliveDurationMs, TimeUnit.MILLISECONDS); } } } @@ -288,9 +292,8 @@ public class Network implements Parcelable { } OkHttpClient client = okUrlFactory.client(); client.setSocketFactory(getSocketFactory()).setConnectionPool(mConnectionPool); - - // Use internal APIs to change the Network. - Internal.instance.setNetwork(client, mNetwork); + // Let network traffic go via mDns + client.setDns(mDns); return okUrlFactory.open(url); } |