diff options
author | Jonathan Basseri <misterikkit@google.com> | 2017-10-20 02:50:35 +0000 |
---|---|---|
committer | Android (Google) Code Review <android-gerrit@google.com> | 2017-10-20 02:50:35 +0000 |
commit | 7bd96d32a17553cf5772c7abf5a759636bcc4943 (patch) | |
tree | 02bdde6d5a60aef17fcda03d4c7e9ffe88e60b98 | |
parent | c13982c8a84c3d0ea9a4d30965d2609ad2536742 (diff) | |
parent | be530ca6713569d33f9ed78df590b3446139dbfa (diff) | |
download | base-7bd96d32a17553cf5772c7abf5a759636bcc4943.tar.gz |
Merge "DO NOT MERGE Revert "Convert ICarrierService to oneway."" into oc-mr1-dev
-rw-r--r-- | core/java/android/service/carrier/CarrierService.java | 26 | ||||
-rw-r--r-- | core/java/android/service/carrier/ICarrierService.aidl | 3 |
2 files changed, 4 insertions, 25 deletions
diff --git a/core/java/android/service/carrier/CarrierService.java b/core/java/android/service/carrier/CarrierService.java index 2707f1467bcf..813acc232289 100644 --- a/core/java/android/service/carrier/CarrierService.java +++ b/core/java/android/service/carrier/CarrierService.java @@ -17,13 +17,10 @@ package android.service.carrier; import android.annotation.CallSuper; import android.app.Service; import android.content.Intent; -import android.os.Bundle; import android.os.IBinder; import android.os.PersistableBundle; import android.os.RemoteException; -import android.os.ResultReceiver; import android.os.ServiceManager; -import android.util.Log; import com.android.internal.telephony.ITelephonyRegistry; @@ -51,8 +48,6 @@ import com.android.internal.telephony.ITelephonyRegistry; */ public abstract class CarrierService extends Service { - private static final String LOG_TAG = "CarrierService"; - public static final String CARRIER_SERVICE_INTERFACE = "android.service.carrier.CarrierService"; private static ITelephonyRegistry sRegistry; @@ -138,26 +133,11 @@ public abstract class CarrierService extends Service { /** * A wrapper around ICarrierService that forwards calls to implementations of * {@link CarrierService}. - * @hide */ - public class ICarrierServiceWrapper extends ICarrierService.Stub { - /** @hide */ - public static final int RESULT_OK = 0; - /** @hide */ - public static final int RESULT_ERROR = 1; - /** @hide */ - public static final String KEY_CONFIG_BUNDLE = "config_bundle"; - + private class ICarrierServiceWrapper extends ICarrierService.Stub { @Override - public void getCarrierConfig(CarrierIdentifier id, ResultReceiver result) { - try { - Bundle data = new Bundle(); - data.putParcelable(KEY_CONFIG_BUNDLE, CarrierService.this.onLoadConfig(id)); - result.send(RESULT_OK, data); - } catch (Exception e) { - Log.e(LOG_TAG, "Error in onLoadConfig: " + e.getMessage(), e); - result.send(RESULT_ERROR, null); - } + public PersistableBundle getCarrierConfig(CarrierIdentifier id) { + return CarrierService.this.onLoadConfig(id); } } } diff --git a/core/java/android/service/carrier/ICarrierService.aidl b/core/java/android/service/carrier/ICarrierService.aidl index ac6f9614d8f5..4c875851cfc8 100644 --- a/core/java/android/service/carrier/ICarrierService.aidl +++ b/core/java/android/service/carrier/ICarrierService.aidl @@ -17,7 +17,6 @@ package android.service.carrier; import android.os.PersistableBundle; -import android.os.ResultReceiver; import android.service.carrier.CarrierIdentifier; /** @@ -29,5 +28,5 @@ import android.service.carrier.CarrierIdentifier; interface ICarrierService { /** @see android.service.carrier.CarrierService#onLoadConfig */ - oneway void getCarrierConfig(in CarrierIdentifier id, in ResultReceiver result); + PersistableBundle getCarrierConfig(in CarrierIdentifier id); } |