summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristopher Dombroski <cdombroski@google.com>2019-04-16 13:21:39 -0700
committerJP Sugarbroad <jpsugar@google.com>2019-08-07 14:12:56 -0700
commit36168195b48231f044bd4af23ea667fa1b514c6d (patch)
treea67c8b97c38665e8150625265608f28f4c0c3e04
parent205355ee59dc5d5ef225a024c3bc66272428c0d8 (diff)
downloadbase-36168195b48231f044bd4af23ea667fa1b514c6d.tar.gz
OP_REQUEST_INSTALL_PACKAGES denied by default
Some system apps may download unknown content and the user should be explicitly asked whether they trust these files. System apps should explicitly use the extra NOT_UNKNOWN_SOURCE to bypass this check. Test: Builds, boots, existing tests pass: atest CtsPackageInstallTestCases Locally verified they pass if CtsPackageInstallTestCases.apk was signed by the platform cert. Bug: 123700348 Change-Id: I3028bf8ff3f79a41521deeee43fba3c32bb1b2ca Merged-In: I2578251906f6656b83464d1c4fc4db99165841c9 (cherry picked from commit 43e682abef2a1c65585bef510c390480f0c4a2fd)
-rw-r--r--services/core/java/com/android/server/pm/PackageManagerService.java6
1 files changed, 2 insertions, 4 deletions
diff --git a/services/core/java/com/android/server/pm/PackageManagerService.java b/services/core/java/com/android/server/pm/PackageManagerService.java
index 132f3040d207..0a509146df22 100644
--- a/services/core/java/com/android/server/pm/PackageManagerService.java
+++ b/services/core/java/com/android/server/pm/PackageManagerService.java
@@ -25853,11 +25853,9 @@ Slog.v(TAG, ":: stepped forward, applying functor at tag " + parser.getName());
}
if (mExternalSourcesPolicy != null) {
int isTrusted = mExternalSourcesPolicy.getPackageTrustedToInstallApps(packageName, uid);
- if (isTrusted != PackageManagerInternal.ExternalSourcesPolicy.USER_DEFAULT) {
- return isTrusted == PackageManagerInternal.ExternalSourcesPolicy.USER_TRUSTED;
- }
+ return isTrusted == PackageManagerInternal.ExternalSourcesPolicy.USER_TRUSTED;
}
- return checkUidPermission(appOpPermission, uid) == PERMISSION_GRANTED;
+ return false;
}
@Override