summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-09-15Merge cherrypicks of ['googleplex-android-review.googlesource.com/24308899', ↵android-14.0.0_r15android-14.0.0_r14android-14.0.0_r13android14-s2-releaseandroid14-releaseAndroid Build Coastguard Worker
'googleplex-android-review.googlesource.com/24310240', 'googleplex-android-review.googlesource.com/23727470', 'googleplex-android-review.googlesource.com/24444452', 'googleplex-android-review.googlesource.com/24424817', 'googleplex-android-review.googlesource.com/24248274', 'googleplex-android-review.googlesource.com/24484185', 'googleplex-android-review.googlesource.com/24499883', 'googleplex-android-review.googlesource.com/24681253', 'googleplex-android-review.googlesource.com/24499331', 'googleplex-android-review.googlesource.com/24485253', 'googleplex-android-review.googlesource.com/24026633', 'googleplex-android-review.googlesource.com/24499047', 'googleplex-android-review.googlesource.com/24422641', 'googleplex-android-review.googlesource.com/24733945', 'googleplex-android-review.googlesource.com/24677183', 'googleplex-android-review.googlesource.com/24708071', 'googleplex-android-review.googlesource.com/24758914'] into udc-release. Change-Id: I8023576b9abf5d7976ab4ded6a1c803001da870b
2023-09-15Fix NPE in TTS service if no engine stringFelix Oghina
Test: added test in TextToSpeechServiceTest Bug: 232438498 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:e5364f93d3208a66d599d7256d2e4cfaba989e0e) Merged-In: Ia587d34e2898930c0956024c56a1f19debb445e4 Change-Id: Ia587d34e2898930c0956024c56a1f19debb445e4
2023-09-15Store trusted AttributionSources without tokenNate Myren
Storing them with token means that there is a strong reference to the token, preventing the WeakHashMap from properly purging values This CP also includes changeID I5731ceeab5b9d0c72ce0131e2c9ba2f74558218c Bug: 298253183 Test: manual (for WeakHashMap ejection) atest CtsAttributionSourceTestCases (cherry picked from commit ed57878c8e89d136264ed419590a0601bdfa18f6) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:c5127b478d0b1e72aa60783fcb4f1f1254d01075) Merged-In: Ie92b76ec83552cebb419318c214057f1ea8455d2 Change-Id: Ie92b76ec83552cebb419318c214057f1ea8455d2
2023-09-15Do not register OnBackInvokedCallback for SoftInputWindow.wilsonshih
By default Dialog#onStart will register onBackInvokedCallback, which should be necessary since InputMethodService will register CompatOnBackInvokedCallback for input method window. Bug: 294162707 Test: atest BackGestureInvokedTest Test: manual, launch Calendar then trigger back several times, verify the back gesture can close app normally. (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:da6336c35396bbea2191cb0e6b4aa72272a8059a) Merged-In: Icacfef60666fba1522f9d0f4ddc47e74a4560a32 Change-Id: Icacfef60666fba1522f9d0f4ddc47e74a4560a32
2023-09-15Restore trimMemory behaviour from TJernej Virag
When we moved trimming code to ResourceTrimmer in I84637049a106a94bf9f06c5261c2941b55db4ba0, we also moved trimMemory(ComponentCallbacks2.TRIM_MEMORY_UI_HIDDEN) which happens after unlock from StatusBarKeyguardViewManager to the ResourceTrimmer behind a TRIM_FONT_CACHES_AT_UNLOCK flag. Now that we've disabled TRIM_FONT_CACHES_AT_UNLOCK, this also disabled the trimMemory call we were doing since way before Android U. To full restore pre-U trim font behaviour, this call should not be flag guarded behind the font caching flag. Bug: 275486055 Bug: 290898642 Bug: 293929945 Test: Updated unit tests (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4bc215c4101b9504c244356ad0264ea1f4912bbd) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:16a1cf9e654bcaf3618213df7b9e82db3bdb5d40) Merged-In: I677855fff144a53d212b65575111491c78803817 Change-Id: I677855fff144a53d212b65575111491c78803817
2023-09-15Unregister mShowWeatherObserver when KeyguardClockSwitchController is detachedHawkwood Glazier
Bug: 295143740 Bug: 293929945 Test: Manually checked codepath with secondary display (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:dea88a049ba8eabe381b5a5318dd77b5aa1d186f) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:c9c3e0f81a9c3037d06c7ffa8c66d08d74f0cf40) Merged-In: I8807d1d58b58f1e5c990c21cef6a810e8b13c1db Change-Id: I8807d1d58b58f1e5c990c21cef6a810e8b13c1db
2023-09-15AudioDeviceBroker: restore use of hearing aids by default for VoIP callsEric Laurent
Remove the target SDK gating policy for the selection of hearing aids during VoIP calls: this could break legacy apps that did not adopt new APIs to manage hearing aids. Bug: 295220577 Test: Meets, Skype, Zoom and Celluar calls with hearing aids. (cherry picked from commit 97014effc039f44910f86a1151a3af375c944926) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:6db4ead48e50356918e28594b13c31defdf009a1) Merged-In: I9e4abfe6d22ac48f50bdec362597a028359dcc9f Change-Id: I9e4abfe6d22ac48f50bdec362597a028359dcc9f
2023-09-15Fix back gesture / keycode for the PlatLogoActivityDan Sandler
By overriding onKeyUp on the Activity itself, without calling super, I broke legacy back handling. Fortunately, there is now a better way to handle back! (Also fix the theme to avoid wallpaper showing through display cutout insets.) Test: adb shell input keyevent --longpress KEYCODE_BACK Test: swipe from edge Fixes: 289648693 Fixes: 290989795 (cherry picked from commit 5bbab52e0062877e17579bec48031f06ded79963) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:eeacd7d3f11f204057da54a8229eab3b18a08a93) Merged-In: I4fd4975421d204f06dbd8acda1a0d2a5a99f3465 Change-Id: I4fd4975421d204f06dbd8acda1a0d2a5a99f3465
2023-09-15Limit ordering unlock and wake by configuration.Bryce Lee
This change limits sequencing unlock and wake to only devices where the configuration has been enabled. Test: atest KeyguardViewMediatorTest Test: atest BiometricsUnlockControllerTest Bug: 289861878 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:45c5e0412c4e9e5c2947f24582e905af1f6b3235) Merged-In: I2bdf8bb16dba693c4afb824e861ab4b87783d61b Change-Id: I2bdf8bb16dba693c4afb824e861ab4b87783d61b
2023-09-15Fallback to default display if initial one is detachedCharles Chen
Test: atest WindowContextTests Fixes: 285630617 (cherry picked from commit 7d860098f5c585c96ce29b199b36f7c82b938249) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:01bd9ec4ceb5da65235d0840c723d9b422168850) Merged-In: I196bab294c182230edda54241f7b725f44f05570 Change-Id: I196bab294c182230edda54241f7b725f44f05570
2023-09-15Fix NPE when fetch shortcut icon uriPinyao Ting
Bug: 296980481 Test: atest CtsShortcutManagerTestCases (cherry picked from commit 879e92bb81de34d5d0eb341f67e0c2d6a8ba8b43) (cherry picked from commit a1c34f0aac5acb50b1c912e2c96d9ef7a6a79348) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:76524da868c0619ea2ce43e7ae94f1655945f8f1) Merged-In: I7a2e85c703d2758f89b0c06d898f9423d6764444 Change-Id: I7a2e85c703d2758f89b0c06d898f9423d6764444
2023-09-15Select the default clock if current clock id was not foundHawkwood Glazier
Bug: 295371293 Test: Manually tested invalid clock ids (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:6194a27664896ff9cbae646483659959dfb3aca8) Merged-In: I98d96bf72cbe09895b644a5a53f86499bf74bfab Change-Id: I98d96bf72cbe09895b644a5a53f86499bf74bfab
2023-09-15Update autoHandwritingEnabled documentationJustin Ghan
Since we are changing the default value to false in UDC QPR1, remove the default value specification from the documentation. Bug: 296586357 Test: N/A (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:8ee1665bcfe83c9481ccf867742853e846f2e332) Merged-In: Iad6e5b858503617b4a38045fbf32984c0d03619a Change-Id: Iad6e5b858503617b4a38045fbf32984c0d03619a
2023-09-15Fixes update ownership preapproval flowPatrick Baumann
This change sets the package name when computing commit preapproval reason. Previously, with the package name unavailable that path would not be able to look up the existing package and so wouldn't know the owner. Additionally, if the installer required user action, the wrong dialog would have been displayed when the update ownership dialog should have been. This fixes both issues. Add new change id to check whether the build includes the fix or not. If the change is disabled, it means the build includes the fix. If the build doesn't include the change id, when the caller checks the change, it is enabled. Bug: 293644536 Test: atest PreapprovalInstallTest UpdateOwnershipEnforcementTest (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:917f02221653e456d83bf58cdfd7f86a54789909) Merged-In: I210fe1bb13a2096eb7e087806298ed1d4fa4905d Change-Id: I210fe1bb13a2096eb7e087806298ed1d4fa4905d
2023-09-15[SettingsProvider] verify ringtone URI before settingSongchun Fan
Similar to ag/24422287, but the same URI verification should be done in SettingsProvider as well, which can be called by apps via Settings.System API or ContentProvider APIs without using RingtoneManager. BUG: 227201030 Test: manual with a test app. Will add a CTS test. (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:1b234678ec122994ccbfc52ac48aafdad7fdb1ed) Merged-In: Ic0ffa1db14b5660d02880b632a7f2ad9e6e5d84b Change-Id: Ic0ffa1db14b5660d02880b632a7f2ad9e6e5d84b
2023-09-15Prevent media button receivers targeting activitiesIván Budnik
This enforcement prevents a bypass of background activity launches. For Android U, the enforcement just ignores the request and logs a warning. This change is a backport of ag/23810567. Test: Manually. Bug: 272737196 Bug: 272024837 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:d455e21711c167223f7d0696809a4e411683182c) Merged-In: I2412633c0b3afda6776244c72043d0dd78a4c8a1 Change-Id: I2412633c0b3afda6776244c72043d0dd78a4c8a1
2023-09-15Fix BAL via notification.publicVersionNan Wu
We stripped the token that allows app to retrieve their own notification and fire their own PI to launch activities from background. But we forgot to strip the token from notification.publicVersion Bug: 278558814 Test: NotificationManagerTest#testActivityStartFromRetrievedNotification_isBlocked (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:e79cbff7f85ea5497dcdb27b13535e4e3ac9913f) Merged-In: I8f25d7a5e47890a0496af023149717e1df482f98 Change-Id: I8f25d7a5e47890a0496af023149717e1df482f98
2023-09-15Use type safe API of readParcelableArraykumarashishg
Bug: 291299076 Test: Build and flash the device and check if it throws exception for non UsbInterface object Test: atest CtsUsbManagerTestCases (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:85d7e6712a9eeeed3bdd68ea3c3862c7e88bfe70) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2c9931533cf8f85de9feb1db0b9ad38b8837f3b8) Merged-In: I2917c8331b6d56caaa9a6479bcd9a2d089f5f503 Change-Id: I2917c8331b6d56caaa9a6479bcd9a2d089f5f503
2023-09-15[DO NOT MERGE] Check caller's uid in backupAgentCreated callbackPiyush Mehrotra
AM.backupAgentCreated() should enforce that caller belongs the package called in the API. Bug: 289549315 Test: atest android.security.cts.ActivityManagerTest#testActivityManager_backupAgentCreated_rejectIfCallerUidNotEqualsPackageUid (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:859abb58cdc7d66dbd22e7d02994509c4bba0416) Merged-In: I9f3ae5ec0b8f00e020d471cc0eddf8bd8bdbb82d Change-Id: I9f3ae5ec0b8f00e020d471cc0eddf8bd8bdbb82d
2023-08-30Merge cherrypicks of ['googleplex-android-review.googlesource.com/24592263'] ↵android-14.0.0_r2android-14.0.0_r1android14-s1-releaseAndroid Build Coastguard Worker
into udc-release. Change-Id: I41d24af95f967c2c803650c671863991a3ea3524
2023-08-30Fix possible leaks in CanvasContext HintSessionWrapperMatt Buckley
Ensure the mHintSessionFuture is accounted for correctly in the destructor. Bug: b/297230599 Test: manual (cherry picked from commit ac620f64a32500890007b0b405ca72405d6db41e) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:e4b73a7aa058be845d3ee2433b8da99fc524d7c1) Merged-In: Idcbd0f2ba87290f090d693f0a64cb46fe8270b95 Change-Id: Idcbd0f2ba87290f090d693f0a64cb46fe8270b95
2023-08-22Merge cherrypicks of ['googleplex-android-review.googlesource.com/24506937'] ↵Android Build Coastguard Worker
into udc-release. Change-Id: I63f8a0d60e05c2ae57d3ef2404bb4f21fd386767
2023-08-22Revert "Import translations. DO NOT MERGE ANYWHERE"Lokesh Kumar Goel
This reverts commit 5e7f8d8aca7b040f5ab57af3af4a72095d425e0c. Reason for revert: coastguard doesn't flag the resource file CLs as already merged. Instead cherry-picked it again causing build failure with error: frameworks/base/packages/SystemUI/res/values-zh-rCN/strings.xml:966: error: duplicate value for resource 'string/controls_media_empty_title' with config 'zh-rCN'. frameworks/base/packages/SystemUI/res/values-zh-rCN/strings.xml:966: error: resource previously defined here. frameworks/base/packages/SystemUI/res/values-zh-rCN/strings.xml: error: file failed to compile BUG:296960974 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:202164834a9139bdf1ec1e53b65c3911002f2909) Merged-In: I20fe50d806dc799328da7a594cfd42b5c20b4f02 Change-Id: I20fe50d806dc799328da7a594cfd42b5c20b4f02
2023-08-22Merge cherrypicks of ['googleplex-android-review.googlesource.com/21027159', ↵Android Build Coastguard Worker
'googleplex-android-review.googlesource.com/23770590', 'googleplex-android-review.googlesource.com/23785419', 'googleplex-android-review.googlesource.com/23675944', 'googleplex-android-review.googlesource.com/23772077', 'googleplex-android-review.googlesource.com/23891752', 'googleplex-android-review.googlesource.com/23545766', 'googleplex-android-review.googlesource.com/24126330', 'googleplex-android-review.googlesource.com/24281855', 'googleplex-android-review.googlesource.com/24150805', 'googleplex-android-review.googlesource.com/24026547', 'googleplex-android-review.googlesource.com/24284551', 'googleplex-android-review.googlesource.com/24034687', 'googleplex-android-review.googlesource.com/24300598', 'googleplex-android-review.googlesource.com/24325540', 'googleplex-android-review.googlesource.com/24116150', 'googleplex-android-review.googlesource.com/24239788'] into udc-release. Change-Id: Iffdcd617b2dbe1c72dc952747a2d80c925cd8feb
2023-08-22Only create InsetsSourceConsumer for InsetsSourceControlTiger
Previously, the insets source consumer is only created if the insets source exists. However, if a control target is not below an insets source, the target won't receive the source, and the consumer won't be created, and the insets cannot be controlled. Also, InsetsSourceConsumer only works when the control exists. So we don't have to create redundant consumers for types not controllable. This CL only creates the insets source consumer for the control, not for the source. This fixes the z-order problem. Fix: 290884763 Bug: 234093736 Test: atest InsetsControllerTest InsetsSourceConsumerTest ImeInsetsSourceConsumerTest Test: Watch a video in Google TV. Long press an icon on taskbar before taskbar fades out. See if taskbar is visible. (cherry picked from commit aa27825aff00b69d0a77db6143c52acfa22a41a6) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:28fc69cb89c8090ea8dabbeb2ebf3b5baeedd1f1) Merged-In: I16a854d52f46d36899c826426afc5ebbcf47b586 Change-Id: I16a854d52f46d36899c826426afc5ebbcf47b586
2023-08-22Add a flag byForegroundService to enqueueNotification() call.Hui Yu
This flag is passed to NotificationManagerService, the CallStyle check will treat byForegroundService flag same as isFgs flag. Only the ServiceRecord.postNotification() call at startForeground() call has byForegroundService flag set to true. Add a test case NotificationManagerServiceTest.java#checkCallStyleNotification_allowedForByForegroundService Bug: 280003654 Test: atest NotificationManagerServiceTest.java#checkCallStyleNotification_allowedForByForegroundService (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:ea56bb0813c03d4b9d14795da979da8c86b8ccb1) Merged-In: Ibe30526ac0ff52e2e4fe9bc846576509cdf78236 Change-Id: Ibe30526ac0ff52e2e4fe9bc846576509cdf78236
2023-08-22Fix large clock flickers when animated in FelixSherry Zhou
Test: Manual Bug: 292063872 (cherry picked from commit 67e010a85590419741a14c2833c496f7bd3ac96d) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:81c029c22087b8d1d76eca1ac78e2ef027db0aeb) Merged-In: I036f3a5ad60faf2525fcc231c6295a3854b19b85 Change-Id: I036f3a5ad60faf2525fcc231c6295a3854b19b85
2023-08-22RESTRICT AUTOMERGE: SettingsProvider: exclude secure_frp_mode from resetsEric Biggers
When RescueParty detects that a system process is crashing frequently, it tries to recover in various ways, such as by resetting all settings. Unfortunately, this included resetting the secure_frp_mode setting, which is the means by which the system keeps track of whether the Factory Reset Protection (FRP) challenge has been passed yet. With this setting reset, some FRP restrictions went away and it became possible to bypass FRP by setting a new lockscreen credential. Fix this by excluding secure_frp_mode from resets. Note: currently this bug isn't reproducible on 'main' due to ag/23727749 disabling much of RescueParty, but that is a temporary change. Bug: 253043065 Test: With ag/23727749 reverted and with my fix to prevent com.android.settings from crashing *not* applied, tried repeatedly setting lockscreen credential while in FRP mode, using the smartlock setup activity launched by intent via adb. Verified that although RescueParty is still triggered after 5 attempts, secure_frp_mode is no longer reset (its value remains "1"). Test: Verified that secure_frp_mode still gets changed from 1 to 0 when FRP is passed legitimately. Test: atest com.android.providers.settings.SettingsProviderTest Test: atest android.provider.SettingsProviderTest (cherry picked from commit 9890dd7f15c091f7d1a09e4fddb9f85d32015955) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:1c3d701c60015f379bc231450c8c8f86d463d6fd) Merged-In: Id95ed43b9cc2208090064392bcd5dc012710af93 Change-Id: Id95ed43b9cc2208090064392bcd5dc012710af93
2023-08-22Change behind-scrim's tint in BOUNCER state to match GM3 surface color.Mike Schneider
This is in lieu of relying on the KeyguardSecurityContainer to paint the background with surfaceColor. It fixes an issue during KeyguardSecurityContainer's vertical translation, triggered either via a gesture or during the bouncer dismiss animation, where the wrong color tone is surfaced and the alpha fades conflict. Bug: 281965452 Test: unit tests Test: manually tested bouncer on large screen, incl theme change http://shortn/_DVOtSJtrwy (cherry picked from commit d71e5c8fe2db8e8b0dab26c5979c576a88243316) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:83b55b6a673170d162dd315a6711ff42603c74ba) Merged-In: I67149c6faa2766be6d2537f2315dd2734bdd0447 Change-Id: I67149c6faa2766be6d2537f2315dd2734bdd0447
2023-08-22Fix biometric context update problem.Vincent Wang
Bug: b/288761850 Test: Check b/288761850 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a7c50568f6e09782429b31eedd547bf72b001d30) Merged-In: I890d102d10a3efa230e26e4e9753f9c66b71afdb Change-Id: I890d102d10a3efa230e26e4e9753f9c66b71afdb
2023-08-22[Status Bar] Set status bar window insets to status bar height always.Caitlin Shkuratov
This is needed for the animation shown when you tap the ongoing call chip in order to launch the call app. If we do *not* set the insets, then the insets will change during the animation, which will result in the animation being cancelled and show jank when launching the app. This CL is improvement of ag/23875866. That CL originally caused b/290300359, where the status bar height changed but the insets were *not* changed, so the insets were too small. This CL also adds the insets to the #applyHeight function, which is called when the status bar height changes. Bug: 283958440 Test: tap on ongoing call chip -> verify no jank during animation Test: status bar smoke test on phone (verify status bar in portrait and landscape, with and without ongoing call chip) Test: status bar smoke test on tablet (same as above) Test: status bar smoke test on foldable (same as above) Test: regression test for b/290300359: Boot foldable device while unfolded (no display cutout) > fold device (has display cutout now) > open app > verify there's no white/black bar showing between the status bar and the app (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4b89585868f4c95b2458bb1eef77587a896751a7) Merged-In: I35df87ef05cb75dcd551cc4899a0a9863fdcbcc7 Change-Id: I35df87ef05cb75dcd551cc4899a0a9863fdcbcc7
2023-08-22[MediaProjection] Address deadlock between multiple servicesNaomi Musgrave
Below outlines acceptable lock ordering: * WindowManagerService -> MediaProjectionManagerService * ActivityManagerService -> WindowManagerService This change addresses deadlock caused by MediaProjectionManagerService -> ActivityManagerService by ensuring that MPMS -> AMS is never done while holding the MPMS lock. Bug: 291826358 Test: Manual & asking partner to validate monkey test (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:0003ce7a48a148f3f4b842e473d9ff8854af281d) Merged-In: I63037ea099699ac9dba87086ea8caf0082e0c721 Change-Id: I63037ea099699ac9dba87086ea8caf0082e0c721
2023-08-22Enable insets cache for display switchRiddle Hsu
To reduce latency of physical display switch. Bug: 266197298 Bug: 293131586 Bug: 292472402 Test: Check latency of fold/unfold. (cherry picked from commit 5dfc7882dfa7431f8d3df257fe59ebfaa15705e2) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:b71e95146f2c2241ab48c4602e4cbcec87d246da) Merged-In: Id2e796edee45dae281f867c2b1549a80984c8a8e Change-Id: Id2e796edee45dae281f867c2b1549a80984c8a8e
2023-08-22Allow shell to control transition animationsRobin Lee
Test: atest 'CtsSecurityTestCases:android.security.cts.ActivityManagerTest#testActivityManager_stripTransitionFromActivityOptions' Bug: 286882367 Bug: 290586831 Bug: 237290578 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:0be0367ece4d946de576f7bb1e6e6777633a736d) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:8bddf5091e0bf4e8252abc66169a7bcc9459001a) Merged-In: Iffe5625ae57c21874805ef98b67faac9f56f87f5 Change-Id: Iffe5625ae57c21874805ef98b67faac9f56f87f5
2023-08-22Fixing DatabaseUtils to detect malformed UTF-16 stringsKunal Malhotra
Test: tested with POC in bug, also using atest Bug: 224771621 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:0e371afb3000c499e0781168ec881a47eab93bad) Merged-In: Ide65205b83063801971c5778af3154bcf3f0e530 Change-Id: Ide65205b83063801971c5778af3154bcf3f0e530
2023-08-22Add userId check before loading icon in Device ControlsAnton Potapov
Test: manual with the steps from the bug Test: manual with a normal icon Test: atest CanUseIconPredicate Test: atest ControlViewHolderTest Bug: 272025416 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:0c32739fabc2b49104fb6aacd9c3ce76183aed14) Merged-In: I39b7bc62d82e20b5ba8747be13a2aa7bf21a59a2 Change-Id: I39b7bc62d82e20b5ba8747be13a2aa7bf21a59a2
2023-08-22[DO NOT MERGE] Verify URI Permissions in Autofill RemoteViewsTim Yu
Check permissions of URI inside of FillResponse's RemoteViews. If the current user does not have the required permissions to view the URI, the RemoteView is dropped from displaying. This fixes a security spill in which a user can view content of another user through a malicious Autofill provider. Bug: 283137865 Fixes: b/283264674 b/281666022 b/281665050 b/281848557 b/281533566 b/281534749 b/283101289 Test: Verified by POC app attached in bugs Test: atest CtsAutoFillServiceTestCases (added new tests) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:ad7af76515094a9e8141ed74ef38abef538c563a) Merged-In: I6f4d2a35e89bbed7bd9e07bf5cd3e2d68b20af9a Change-Id: I6f4d2a35e89bbed7bd9e07bf5cd3e2d68b20af9a
2023-08-22Update parcling logic for Uris.Varun Shah
Implicitly convert all Uris to StringUris during parcel read/write. Bug: 231476072 Test: atest UriTest (cherry picked from commit 98bc5f99b14239aa871a998548ad80a076756318) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a28766a56ca0457ce3891f1f5bc8514126123a79) Merged-In: Ic7688a00a07705301e5b06ee8783e801395e9f15 Change-Id: Ic7688a00a07705301e5b06ee8783e801395e9f15
2023-08-22Do not share key mappings with JNI objectJosep del Rio
The key mapping information between the native key mappings and the KeyCharacterMap object available in Java is currently shared, which means that a read can be attempted while it's being modified. Bug: 274058082 Test: Patch tested by Oppo (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3d993de0d1ada8065d1fe561f690c8f82b6a7d4b) Merged-In: I745008a0a8ea30830660c45dcebee917b3913d13 Change-Id: I745008a0a8ea30830660c45dcebee917b3913d13
2023-08-22Import translations. DO NOT MERGE ANYWHEREBill Yi
BUG:286996125 Auto-generated-cl: translation import (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:7aa5b1415941f8c4172d02072f59349d30450232) Merged-In: Ic6ab0430324902d7fe42feb491c2b92a13e8bc17 Change-Id: Ic6ab0430324902d7fe42feb491c2b92a13e8bc17
2023-08-22RingtoneManager: verify default ringtone is audioJean-Michel Trivi
When a ringtone picker tries to set a ringtone through RingtoneManager.setActualDefaultRingtoneUri (also called by com.android.settings.DefaultRingtonePreference), verify the mimeType can be obtained (not found when caller doesn't have access to it) and it is an audio resource. Bug: 205837340 Test: atest android.media.audio.cts.RingtoneManagerTest (cherry picked from commit 38618f9fb16d3b5617e2289354d47abe5af17dad) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:88f5aae54cf522e4ec50c2dbf2c782872734db00) Merged-In: I3f2c487ded405c0c1a83ef0a2fe99cff7cc9328e Change-Id: I3f2c487ded405c0c1a83ef0a2fe99cff7cc9328e
2023-08-20[coastguard skipped] Merge sparse cherrypicks from ↵Android Build Coastguard Worker
sparse-10685236-L90500000962658543 into udc-release. COASTGUARD_SKIP: Ibd50eb67d1c943c69d7757b29579f01a59cd09fa COASTGUARD_SKIP: I35df87ef05cb75dcd551cc4899a0a9863fdcbcc7 COASTGUARD_SKIP: Id2e796edee45dae281f867c2b1549a80984c8a8e COASTGUARD_SKIP: I890d102d10a3efa230e26e4e9753f9c66b71afdb COASTGUARD_SKIP: I67149c6faa2766be6d2537f2315dd2734bdd0447 Change-Id: I36f5ca4adedee5d3f014a4ed385b9c5ac9364680
2023-08-20Merge cherrypicks of ['googleplex-android-review.googlesource.com/24281855', ↵Android Build Coastguard Worker
'googleplex-android-review.googlesource.com/24026547', 'googleplex-android-review.googlesource.com/24284551', 'googleplex-android-review.googlesource.com/24034687'] into sparse-10685236-L90500000962658543. SPARSE_CHANGE: Id2e796edee45dae281f867c2b1549a80984c8a8e SPARSE_CHANGE: I35df87ef05cb75dcd551cc4899a0a9863fdcbcc7 SPARSE_CHANGE: I890d102d10a3efa230e26e4e9753f9c66b71afdb SPARSE_CHANGE: I67149c6faa2766be6d2537f2315dd2734bdd0447 Change-Id: Ibd50eb67d1c943c69d7757b29579f01a59cd09fa
2023-08-20Change behind-scrim's tint in BOUNCER state to match GM3 surface color.Mike Schneider
This is in lieu of relying on the KeyguardSecurityContainer to paint the background with surfaceColor. It fixes an issue during KeyguardSecurityContainer's vertical translation, triggered either via a gesture or during the bouncer dismiss animation, where the wrong color tone is surfaced and the alpha fades conflict. Bug: 281965452 Test: unit tests Test: manually tested bouncer on large screen, incl theme change http://shortn/_DVOtSJtrwy (cherry picked from commit d71e5c8fe2db8e8b0dab26c5979c576a88243316) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:83b55b6a673170d162dd315a6711ff42603c74ba) Merged-In: I67149c6faa2766be6d2537f2315dd2734bdd0447 Change-Id: I67149c6faa2766be6d2537f2315dd2734bdd0447
2023-08-20Fix biometric context update problem.Vincent Wang
Bug: b/288761850 Test: Check b/288761850 (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a7c50568f6e09782429b31eedd547bf72b001d30) Merged-In: I890d102d10a3efa230e26e4e9753f9c66b71afdb Change-Id: I890d102d10a3efa230e26e4e9753f9c66b71afdb
2023-08-20[Status Bar] Set status bar window insets to status bar height always.Caitlin Shkuratov
This is needed for the animation shown when you tap the ongoing call chip in order to launch the call app. If we do *not* set the insets, then the insets will change during the animation, which will result in the animation being cancelled and show jank when launching the app. This CL is improvement of ag/23875866. That CL originally caused b/290300359, where the status bar height changed but the insets were *not* changed, so the insets were too small. This CL also adds the insets to the #applyHeight function, which is called when the status bar height changes. Bug: 283958440 Test: tap on ongoing call chip -> verify no jank during animation Test: status bar smoke test on phone (verify status bar in portrait and landscape, with and without ongoing call chip) Test: status bar smoke test on tablet (same as above) Test: status bar smoke test on foldable (same as above) Test: regression test for b/290300359: Boot foldable device while unfolded (no display cutout) > fold device (has display cutout now) > open app > verify there's no white/black bar showing between the status bar and the app (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4b89585868f4c95b2458bb1eef77587a896751a7) Merged-In: I35df87ef05cb75dcd551cc4899a0a9863fdcbcc7 Change-Id: I35df87ef05cb75dcd551cc4899a0a9863fdcbcc7
2023-08-20Enable insets cache for display switchRiddle Hsu
To reduce latency of physical display switch. Bug: 266197298 Bug: 293131586 Bug: 292472402 Test: Check latency of fold/unfold. (cherry picked from commit 5dfc7882dfa7431f8d3df257fe59ebfaa15705e2) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:b71e95146f2c2241ab48c4602e4cbcec87d246da) Merged-In: Id2e796edee45dae281f867c2b1549a80984c8a8e Change-Id: Id2e796edee45dae281f867c2b1549a80984c8a8e
2023-08-20[coastguard skipped] Merge sparse cherrypicks from ↵Android Build Coastguard Worker
sparse-10685236-L61400000962657635 into udc-release. COASTGUARD_SKIP: Ibf1837a7c895577a9f69777bc24725efa152b32a COASTGUARD_SKIP: I67149c6faa2766be6d2537f2315dd2734bdd0447 COASTGUARD_SKIP: I35df87ef05cb75dcd551cc4899a0a9863fdcbcc7 COASTGUARD_SKIP: Id2e796edee45dae281f867c2b1549a80984c8a8e COASTGUARD_SKIP: I890d102d10a3efa230e26e4e9753f9c66b71afdb Change-Id: Icde69f91dfccfd134614130db41aec97444be898
2023-08-20Merge cherrypicks of ['googleplex-android-review.googlesource.com/24281855', ↵Android Build Coastguard Worker
'googleplex-android-review.googlesource.com/24026547', 'googleplex-android-review.googlesource.com/24284551', 'googleplex-android-review.googlesource.com/24034687'] into sparse-10685236-L61400000962657635. SPARSE_CHANGE: Id2e796edee45dae281f867c2b1549a80984c8a8e SPARSE_CHANGE: I35df87ef05cb75dcd551cc4899a0a9863fdcbcc7 SPARSE_CHANGE: I890d102d10a3efa230e26e4e9753f9c66b71afdb SPARSE_CHANGE: I67149c6faa2766be6d2537f2315dd2734bdd0447 Change-Id: Ibf1837a7c895577a9f69777bc24725efa152b32a
2023-08-20Change behind-scrim's tint in BOUNCER state to match GM3 surface color.Mike Schneider
This is in lieu of relying on the KeyguardSecurityContainer to paint the background with surfaceColor. It fixes an issue during KeyguardSecurityContainer's vertical translation, triggered either via a gesture or during the bouncer dismiss animation, where the wrong color tone is surfaced and the alpha fades conflict. Bug: 281965452 Test: unit tests Test: manually tested bouncer on large screen, incl theme change http://shortn/_DVOtSJtrwy (cherry picked from commit d71e5c8fe2db8e8b0dab26c5979c576a88243316) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:83b55b6a673170d162dd315a6711ff42603c74ba) Merged-In: I67149c6faa2766be6d2537f2315dd2734bdd0447 Change-Id: I67149c6faa2766be6d2537f2315dd2734bdd0447