summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKalesh Singh <kaleshsingh@google.com>2022-06-16 01:45:53 -0700
committerKalesh Singh <kaleshsingh@google.com>2022-06-20 15:15:26 -0700
commitd5b5f5acb6f447ea2c72bad4f8bcc2a146f0531a (patch)
treea920d002426afa1dff7e09b4eb29509e38422072
parent33da9468354b9b530712d4157298a8e0479cf2e5 (diff)
downloadnative-d5b5f5acb6f447ea2c72bad4f8bcc2a146f0531a.tar.gz
atrace: Remove persisitent rss_stat_throttled trigger
It was found that the persistent rss_stat_throttled event trigger causes a 8% incease in kswapd CPU usage. So remove this persistent trigger, instead perfetto will dynamically create the trigger when needed. Test: adb push test/configs/rss_stat.cfg /data/local/tmp/ && cf-adb shell 'cat /data/local/tmp/rss_stat.cfg | perfetto --txt -c - -o /data/misc/perfetto-traces/trace Bug: 236172293 Change-Id: I70a978de1fbf2ed538bb869edc715e61aee7efa4 Merged-In: I70a978de1fbf2ed538bb869edc715e61aee7efa4
-rw-r--r--cmds/atrace/atrace.rc7
1 files changed, 2 insertions, 5 deletions
diff --git a/cmds/atrace/atrace.rc b/cmds/atrace/atrace.rc
index 32ffe142cf..5267b0294c 100644
--- a/cmds/atrace/atrace.rc
+++ b/cmds/atrace/atrace.rc
@@ -294,12 +294,9 @@ on late-init
write /sys/kernel/tracing/synthetic_events "rss_stat_throttled unsigned int mm_id; unsigned int curr; int member; long size"
write /sys/kernel/debug/tracing/synthetic_events "rss_stat_throttled unsigned int mm_id; unsigned int curr; int member; long size"
-# Set up histogram triggers
- # rss_stat_throttled (bucket size == 512KB)
- chmod 0666 /sys/kernel/tracing/events/kmem/rss_stat/trigger
+ # allow creating event triggers
chmod 0666 /sys/kernel/debug/tracing/events/kmem/rss_stat/trigger
- write /sys/kernel/tracing/events/kmem/rss_stat/trigger "hist:keys=mm_id,member:bucket=size/0x80000:onchange($$bucket).rss_stat_throttled(mm_id,curr,member,size)"
- write /sys/kernel/debug/tracing/events/kmem/rss_stat/trigger "hist:keys=mm_id,member:bucket=size/0x80000:onchange($$bucket).rss_stat_throttled(mm_id,curr,member,size)"
+ chmod 0666 /sys/kernel/tracing/events/kmem/rss_stat/trigger
# Only create the tracing instance if persist.mm_events.enabled
# Attempting to remove the tracing instance after it has been created