diff options
author | Treehugger Robot <treehugger-gerrit@google.com> | 2016-04-28 15:11:54 +0000 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2016-04-28 15:11:54 +0000 |
commit | a5226fb2cf3d03544da1f9d4d44887c4143e0af0 (patch) | |
tree | 28f7b4851fe1e81e43e57848e84b00f055079fac | |
parent | 3cebac75a29cabec5024a7316117f401b60cc248 (diff) | |
parent | e2347b7953f70232541bdc1b392230d6231aaeb9 (diff) | |
download | native-a5226fb2cf3d03544da1f9d4d44887c4143e0af0.tar.gz |
Merge "Fix google-explicit-constructor warnings."
25 files changed, 27 insertions, 27 deletions
diff --git a/libs/binder/BufferedTextOutput.cpp b/libs/binder/BufferedTextOutput.cpp index 1339a67e62..a2443c081f 100644 --- a/libs/binder/BufferedTextOutput.cpp +++ b/libs/binder/BufferedTextOutput.cpp @@ -34,7 +34,7 @@ namespace android { struct BufferedTextOutput::BufferState : public RefBase { - BufferState(int32_t _seq) + explicit BufferState(int32_t _seq) : seq(_seq) , buffer(NULL) , bufferPos(0) diff --git a/libs/binder/IAppOpsCallback.cpp b/libs/binder/IAppOpsCallback.cpp index 2aaf56679e..f9ec593f77 100644 --- a/libs/binder/IAppOpsCallback.cpp +++ b/libs/binder/IAppOpsCallback.cpp @@ -31,7 +31,7 @@ namespace android { class BpAppOpsCallback : public BpInterface<IAppOpsCallback> { public: - BpAppOpsCallback(const sp<IBinder>& impl) + explicit BpAppOpsCallback(const sp<IBinder>& impl) : BpInterface<IAppOpsCallback>(impl) { } diff --git a/libs/binder/IAppOpsService.cpp b/libs/binder/IAppOpsService.cpp index 9558376dbf..638ae5c8ac 100644 --- a/libs/binder/IAppOpsService.cpp +++ b/libs/binder/IAppOpsService.cpp @@ -31,7 +31,7 @@ namespace android { class BpAppOpsService : public BpInterface<IAppOpsService> { public: - BpAppOpsService(const sp<IBinder>& impl) + explicit BpAppOpsService(const sp<IBinder>& impl) : BpInterface<IAppOpsService>(impl) { } diff --git a/libs/binder/IBatteryStats.cpp b/libs/binder/IBatteryStats.cpp index e32c628679..ad1e69faeb 100644 --- a/libs/binder/IBatteryStats.cpp +++ b/libs/binder/IBatteryStats.cpp @@ -29,7 +29,7 @@ namespace android { class BpBatteryStats : public BpInterface<IBatteryStats> { public: - BpBatteryStats(const sp<IBinder>& impl) + explicit BpBatteryStats(const sp<IBinder>& impl) : BpInterface<IBatteryStats>(impl) { } diff --git a/libs/binder/IMemory.cpp b/libs/binder/IMemory.cpp index e9891a830d..f27b882efc 100644 --- a/libs/binder/IMemory.cpp +++ b/libs/binder/IMemory.cpp @@ -74,7 +74,7 @@ enum { class BpMemoryHeap : public BpInterface<IMemoryHeap> { public: - BpMemoryHeap(const sp<IBinder>& impl); + explicit BpMemoryHeap(const sp<IBinder>& impl); virtual ~BpMemoryHeap(); virtual int getHeapID() const; @@ -122,7 +122,7 @@ enum { class BpMemory : public BpInterface<IMemory> { public: - BpMemory(const sp<IBinder>& impl); + explicit BpMemory(const sp<IBinder>& impl); virtual ~BpMemory(); virtual sp<IMemoryHeap> getMemory(ssize_t* offset=0, size_t* size=0) const; diff --git a/libs/binder/IPermissionController.cpp b/libs/binder/IPermissionController.cpp index 6bba9968bc..674bddf218 100644 --- a/libs/binder/IPermissionController.cpp +++ b/libs/binder/IPermissionController.cpp @@ -31,7 +31,7 @@ namespace android { class BpPermissionController : public BpInterface<IPermissionController> { public: - BpPermissionController(const sp<IBinder>& impl) + explicit BpPermissionController(const sp<IBinder>& impl) : BpInterface<IPermissionController>(impl) { } diff --git a/libs/binder/IProcessInfoService.cpp b/libs/binder/IProcessInfoService.cpp index d86eb27b4d..794588b3ff 100644 --- a/libs/binder/IProcessInfoService.cpp +++ b/libs/binder/IProcessInfoService.cpp @@ -25,7 +25,7 @@ namespace android { class BpProcessInfoService : public BpInterface<IProcessInfoService> { public: - BpProcessInfoService(const sp<IBinder>& impl) + explicit BpProcessInfoService(const sp<IBinder>& impl) : BpInterface<IProcessInfoService>(impl) {} virtual status_t getProcessStatesFromPids(size_t length, /*in*/ int32_t* pids, diff --git a/libs/binder/IServiceManager.cpp b/libs/binder/IServiceManager.cpp index 725ebdf95f..2062b3b509 100644 --- a/libs/binder/IServiceManager.cpp +++ b/libs/binder/IServiceManager.cpp @@ -126,7 +126,7 @@ bool checkPermission(const String16& permission, pid_t pid, uid_t uid) class BpServiceManager : public BpInterface<IServiceManager> { public: - BpServiceManager(const sp<IBinder>& impl) + explicit BpServiceManager(const sp<IBinder>& impl) : BpInterface<IServiceManager>(impl) { } diff --git a/libs/binder/MemoryDealer.cpp b/libs/binder/MemoryDealer.cpp index 8739625693..a5ba4ac811 100644 --- a/libs/binder/MemoryDealer.cpp +++ b/libs/binder/MemoryDealer.cpp @@ -126,7 +126,7 @@ class SimpleBestFitAllocator PAGE_ALIGNED = 0x00000001 }; public: - SimpleBestFitAllocator(size_t size); + explicit SimpleBestFitAllocator(size_t size); ~SimpleBestFitAllocator(); size_t allocate(size_t size, uint32_t flags = 0); diff --git a/libs/binder/ProcessState.cpp b/libs/binder/ProcessState.cpp index 5114ac17a2..4748979da9 100644 --- a/libs/binder/ProcessState.cpp +++ b/libs/binder/ProcessState.cpp @@ -52,7 +52,7 @@ namespace android { class PoolThread : public Thread { public: - PoolThread(bool isMain) + explicit PoolThread(bool isMain) : mIsMain(isMain) { } diff --git a/libs/binder/Static.cpp b/libs/binder/Static.cpp index cd9509f707..f0613d1631 100644 --- a/libs/binder/Static.cpp +++ b/libs/binder/Static.cpp @@ -48,7 +48,7 @@ protected: class FdTextOutput : public BufferedTextOutput { public: - FdTextOutput(int fd) : BufferedTextOutput(MULTITHREADED), mFD(fd) { } + explicit FdTextOutput(int fd) : BufferedTextOutput(MULTITHREADED), mFD(fd) { } virtual ~FdTextOutput() { }; protected: diff --git a/libs/gui/IConsumerListener.cpp b/libs/gui/IConsumerListener.cpp index cab7dc3d5a..9a0b7a4368 100644 --- a/libs/gui/IConsumerListener.cpp +++ b/libs/gui/IConsumerListener.cpp @@ -36,7 +36,7 @@ enum { class BpConsumerListener : public BpInterface<IConsumerListener> { public: - BpConsumerListener(const sp<IBinder>& impl) + explicit BpConsumerListener(const sp<IBinder>& impl) : BpInterface<IConsumerListener>(impl) { } diff --git a/libs/gui/IDisplayEventConnection.cpp b/libs/gui/IDisplayEventConnection.cpp index 9890f44ef7..b1d3b00dbb 100644 --- a/libs/gui/IDisplayEventConnection.cpp +++ b/libs/gui/IDisplayEventConnection.cpp @@ -39,7 +39,7 @@ enum { class BpDisplayEventConnection : public BpInterface<IDisplayEventConnection> { public: - BpDisplayEventConnection(const sp<IBinder>& impl) + explicit BpDisplayEventConnection(const sp<IBinder>& impl) : BpInterface<IDisplayEventConnection>(impl) { } diff --git a/libs/gui/IGraphicBufferAlloc.cpp b/libs/gui/IGraphicBufferAlloc.cpp index 3009989964..d4d470281e 100644 --- a/libs/gui/IGraphicBufferAlloc.cpp +++ b/libs/gui/IGraphicBufferAlloc.cpp @@ -37,7 +37,7 @@ enum { class BpGraphicBufferAlloc : public BpInterface<IGraphicBufferAlloc> { public: - BpGraphicBufferAlloc(const sp<IBinder>& impl) + explicit BpGraphicBufferAlloc(const sp<IBinder>& impl) : BpInterface<IGraphicBufferAlloc>(impl) { } @@ -90,7 +90,7 @@ status_t BnGraphicBufferAlloc::onTransact( class BufferReference : public BBinder { sp<GraphicBuffer> mBuffer; public: - BufferReference(const sp<GraphicBuffer>& buffer) : mBuffer(buffer) {} + explicit BufferReference(const sp<GraphicBuffer>& buffer) : mBuffer(buffer) {} }; diff --git a/libs/gui/IGraphicBufferConsumer.cpp b/libs/gui/IGraphicBufferConsumer.cpp index c4660bad89..334611da61 100644 --- a/libs/gui/IGraphicBufferConsumer.cpp +++ b/libs/gui/IGraphicBufferConsumer.cpp @@ -59,7 +59,7 @@ enum { class BpGraphicBufferConsumer : public BpInterface<IGraphicBufferConsumer> { public: - BpGraphicBufferConsumer(const sp<IBinder>& impl) + explicit BpGraphicBufferConsumer(const sp<IBinder>& impl) : BpInterface<IGraphicBufferConsumer>(impl) { } diff --git a/libs/gui/IGraphicBufferProducer.cpp b/libs/gui/IGraphicBufferProducer.cpp index 1099c84f85..e91a8e1ae6 100644 --- a/libs/gui/IGraphicBufferProducer.cpp +++ b/libs/gui/IGraphicBufferProducer.cpp @@ -54,7 +54,7 @@ enum { class BpGraphicBufferProducer : public BpInterface<IGraphicBufferProducer> { public: - BpGraphicBufferProducer(const sp<IBinder>& impl) + explicit BpGraphicBufferProducer(const sp<IBinder>& impl) : BpInterface<IGraphicBufferProducer>(impl) { } diff --git a/libs/gui/IProducerListener.cpp b/libs/gui/IProducerListener.cpp index 81adc95449..9d18ea23a1 100644 --- a/libs/gui/IProducerListener.cpp +++ b/libs/gui/IProducerListener.cpp @@ -27,7 +27,7 @@ enum { class BpProducerListener : public BpInterface<IProducerListener> { public: - BpProducerListener(const sp<IBinder>& impl) + explicit BpProducerListener(const sp<IBinder>& impl) : BpInterface<IProducerListener>(impl) {} virtual ~BpProducerListener(); diff --git a/libs/gui/ISensorEventConnection.cpp b/libs/gui/ISensorEventConnection.cpp index dc7a35cef9..59ecee7501 100644 --- a/libs/gui/ISensorEventConnection.cpp +++ b/libs/gui/ISensorEventConnection.cpp @@ -40,7 +40,7 @@ enum { class BpSensorEventConnection : public BpInterface<ISensorEventConnection> { public: - BpSensorEventConnection(const sp<IBinder>& impl) + explicit BpSensorEventConnection(const sp<IBinder>& impl) : BpInterface<ISensorEventConnection>(impl) { } diff --git a/libs/gui/ISensorServer.cpp b/libs/gui/ISensorServer.cpp index f581b5c1d4..b0ba134283 100644 --- a/libs/gui/ISensorServer.cpp +++ b/libs/gui/ISensorServer.cpp @@ -41,7 +41,7 @@ enum { class BpSensorServer : public BpInterface<ISensorServer> { public: - BpSensorServer(const sp<IBinder>& impl) + explicit BpSensorServer(const sp<IBinder>& impl) : BpInterface<ISensorServer>(impl) { } diff --git a/libs/gui/ISurfaceComposer.cpp b/libs/gui/ISurfaceComposer.cpp index 78886d5bb6..9bfc90691b 100644 --- a/libs/gui/ISurfaceComposer.cpp +++ b/libs/gui/ISurfaceComposer.cpp @@ -46,7 +46,7 @@ class IDisplayEventConnection; class BpSurfaceComposer : public BpInterface<ISurfaceComposer> { public: - BpSurfaceComposer(const sp<IBinder>& impl) + explicit BpSurfaceComposer(const sp<IBinder>& impl) : BpInterface<ISurfaceComposer>(impl) { } diff --git a/libs/gui/ISurfaceComposerClient.cpp b/libs/gui/ISurfaceComposerClient.cpp index 2ecb9083ff..decffbf9ba 100644 --- a/libs/gui/ISurfaceComposerClient.cpp +++ b/libs/gui/ISurfaceComposerClient.cpp @@ -47,7 +47,7 @@ enum { class BpSurfaceComposerClient : public BpInterface<ISurfaceComposerClient> { public: - BpSurfaceComposerClient(const sp<IBinder>& impl) + explicit BpSurfaceComposerClient(const sp<IBinder>& impl) : BpInterface<ISurfaceComposerClient>(impl) { } diff --git a/libs/gui/SensorManager.cpp b/libs/gui/SensorManager.cpp index 33608b5bd2..9b9e78fef6 100644 --- a/libs/gui/SensorManager.cpp +++ b/libs/gui/SensorManager.cpp @@ -142,7 +142,7 @@ status_t SensorManager::assertStateLocked() const { mSensorManger.sensorManagerDied(); } public: - DeathObserver(SensorManager& mgr) : mSensorManger(mgr) { } + explicit DeathObserver(SensorManager& mgr) : mSensorManger(mgr) { } }; LOG_ALWAYS_FATAL_IF(mSensorServer.get() == NULL, "getService(SensorService) NULL"); diff --git a/libs/gui/SurfaceComposerClient.cpp b/libs/gui/SurfaceComposerClient.cpp index 6ad47d8b71..586379883f 100644 --- a/libs/gui/SurfaceComposerClient.cpp +++ b/libs/gui/SurfaceComposerClient.cpp @@ -67,7 +67,7 @@ void ComposerService::connectLocked() { mComposerService.composerServiceDied(); } public: - DeathObserver(ComposerService& mgr) : mComposerService(mgr) { } + explicit DeathObserver(ComposerService& mgr) : mComposerService(mgr) { } }; mDeathObserver = new DeathObserver(*const_cast<ComposerService*>(this)); diff --git a/libs/input/IInputFlinger.cpp b/libs/input/IInputFlinger.cpp index e00973149c..003e73dae6 100644 --- a/libs/input/IInputFlinger.cpp +++ b/libs/input/IInputFlinger.cpp @@ -28,7 +28,7 @@ namespace android { class BpInputFlinger : public BpInterface<IInputFlinger> { public: - BpInputFlinger(const sp<IBinder>& impl) : + explicit BpInputFlinger(const sp<IBinder>& impl) : BpInterface<IInputFlinger>(impl) { } virtual status_t doSomething() { diff --git a/libs/ui/Region.cpp b/libs/ui/Region.cpp index f7087a931f..2e56543b69 100644 --- a/libs/ui/Region.cpp +++ b/libs/ui/Region.cpp @@ -424,7 +424,7 @@ class Region::rasterizer : public region_operator<Rect>::region_rasterizer Vector<Rect> span; Rect* cur; public: - rasterizer(Region& reg) + explicit rasterizer(Region& reg) : bounds(INT_MAX, 0, INT_MIN, 0), storage(reg.mStorage), head(), tail(), cur() { storage.clear(); } |