summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCalin Juravle <calin@google.com>2019-09-27 13:22:41 -0700
committerCalin Juravle <calin@google.com>2019-09-27 13:22:41 -0700
commit9d25017adff1dd15b68fe5e316160a12b698373f (patch)
treedfef863572017fbbec3e45d6c7550db3b5de59ed
parent6f30b0626e353b6c486c6cc367b59d0c72359281 (diff)
downloadnative-9d25017adff1dd15b68fe5e316160a12b698373f.tar.gz
Remove store_aggregation_counters argument from profile merging
Profiles no longer have aggregation counters and the flag has no effect. Bug: 139884006 Test: m Change-Id: I4af047782933280dd2eb79a94a4da11d8741633e
-rw-r--r--cmds/installd/dexopt.cpp22
1 files changed, 6 insertions, 16 deletions
diff --git a/cmds/installd/dexopt.cpp b/cmds/installd/dexopt.cpp
index 7eee749be9..8cba7e413e 100644
--- a/cmds/installd/dexopt.cpp
+++ b/cmds/installd/dexopt.cpp
@@ -709,8 +709,7 @@ class RunProfman : public ExecVHelper {
const unique_fd& reference_profile_fd,
const std::vector<unique_fd>& apk_fds,
const std::vector<std::string>& dex_locations,
- bool copy_and_update,
- bool store_aggregation_counters) {
+ bool copy_and_update) {
// TODO(calin): Assume for now we run in the bg compile job (which is in
// most of the invocation). With the current data flow, is not very easy or
@@ -742,10 +741,6 @@ class RunProfman : public ExecVHelper {
AddArg("--copy-and-update-profile-key");
}
- if (store_aggregation_counters) {
- AddArg("--store-aggregation-counters");
- }
-
// Do not add after dex2oat_flags, they should override others for debugging.
PrepareArgs(profman_bin);
}
@@ -753,14 +748,12 @@ class RunProfman : public ExecVHelper {
void SetupMerge(const std::vector<unique_fd>& profiles_fd,
const unique_fd& reference_profile_fd,
const std::vector<unique_fd>& apk_fds = std::vector<unique_fd>(),
- const std::vector<std::string>& dex_locations = std::vector<std::string>(),
- bool store_aggregation_counters = false) {
+ const std::vector<std::string>& dex_locations = std::vector<std::string>()) {
SetupArgs(profiles_fd,
reference_profile_fd,
apk_fds,
dex_locations,
- /*copy_and_update=*/false,
- store_aggregation_counters);
+ /*copy_and_update=*/false);
}
void SetupCopyAndUpdate(unique_fd&& profile_fd,
@@ -777,8 +770,7 @@ class RunProfman : public ExecVHelper {
reference_profile_fd_,
apk_fds_,
dex_locations,
- /*copy_and_update=*/true,
- /*store_aggregation_counters=*/false);
+ /*copy_and_update=*/true);
}
void SetupDump(const std::vector<unique_fd>& profiles_fd,
@@ -792,8 +784,7 @@ class RunProfman : public ExecVHelper {
reference_profile_fd,
apk_fds,
dex_locations,
- /*copy_and_update=*/false,
- /*store_aggregation_counters=*/false);
+ /*copy_and_update=*/false);
}
void Exec() {
@@ -2828,8 +2819,7 @@ static bool create_boot_image_profile_snapshot(const std::string& package_name,
args.SetupMerge(profiles_fd,
snapshot_fd,
apk_fds,
- dex_locations,
- /*store_aggregation_counters=*/true);
+ dex_locations);
pid_t pid = fork();
if (pid == 0) {
/* child -- drop privileges before continuing */