diff options
| author | Fabien Sanglard <sanglardf@google.com> | 2016-11-08 15:31:32 -0800 |
|---|---|---|
| committer | Jesse Badash <badash@google.com> | 2016-12-08 22:23:16 +0000 |
| commit | b968aba0239c34ddbae3cc55e49bacca7d0afc1c (patch) | |
| tree | 8b67bce600b94b4c079f81f80b1a0b154940f27a | |
| parent | f14208e0390d8ee20ee4a5d7605d614e8b1abaf1 (diff) | |
| download | native-b968aba0239c34ddbae3cc55e49bacca7d0afc1c.tar.gz | |
Fix SF security vulnerability: 32660278
Because of lack of mutex lock when get mSidebandStream, if one thread
getSidebandStream, another thread setSidebandStream frequently, an UAF
will be triggered.
Bug: 32660278
Test: Marlin device with poc
Change-Id: Idbcf0976ce2db682d0f13455105c45a5c7481a45
(cherry picked from commit 2d8a2432e04234d9edbb3b099f9bbbaa36ad4843)
| -rw-r--r-- | libs/gui/BufferQueueConsumer.cpp | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/libs/gui/BufferQueueConsumer.cpp b/libs/gui/BufferQueueConsumer.cpp index ca2a374e16..73d2042983 100644 --- a/libs/gui/BufferQueueConsumer.cpp +++ b/libs/gui/BufferQueueConsumer.cpp @@ -715,6 +715,7 @@ status_t BufferQueueConsumer::setTransformHint(uint32_t hint) { } sp<NativeHandle> BufferQueueConsumer::getSidebandStream() const { + Mutex::Autolock lock(mCore->mMutex); return mCore->mSidebandStream; } |