diff options
| author | Fabien Sanglard <sanglardf@google.com> | 2016-11-08 15:35:02 -0800 |
|---|---|---|
| committer | Jesse Badash <badash@google.com> | 2016-12-12 21:33:36 +0000 |
| commit | c77ef0e99a8b89ac911187db04179c0fe566dcdf (patch) | |
| tree | 06421e98c287cf861e6a3ba65432036b2a686b35 | |
| parent | 26b8e752e7e6641601497735b8778c32ab777328 (diff) | |
| download | native-c77ef0e99a8b89ac911187db04179c0fe566dcdf.tar.gz | |
Fix SF security vulnerability: 32706020
Because of lack of mutex lock when get mConsumerName, if one thread
getConsumerName, another thread setConsumerName frequently, an UAF will
be triggered.
Change-Id: Id1bbf0d15de6d16def2f54ecade385058cda3b65
Test: Marling with poc provided in bug report.
Bug: 32706020
(cherry picked from commit d073eb7a3f28fd74bfa24c8b7599465cb7de5436)
| -rw-r--r-- | libs/gui/BufferQueueProducer.cpp | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/libs/gui/BufferQueueProducer.cpp b/libs/gui/BufferQueueProducer.cpp index 48b1db8f59..05923b5d35 100644 --- a/libs/gui/BufferQueueProducer.cpp +++ b/libs/gui/BufferQueueProducer.cpp @@ -1352,6 +1352,7 @@ status_t BufferQueueProducer::setGenerationNumber(uint32_t generationNumber) { String8 BufferQueueProducer::getConsumerName() const { ATRACE_CALL(); + Mutex::Autolock lock(mCore->mMutex); BQ_LOGV("getConsumerName: %s", mConsumerName.string()); return mConsumerName; } |