summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSteven Moreland <smoreland@google.com>2020-08-31 21:35:43 +0000
committerSteven Moreland <smoreland@google.com>2020-08-31 21:39:05 +0000
commit23c30e9e86e097695a2237cbe482c78d6d5ed076 (patch)
treeeb5164f34535b29935269d6d958a926d0a9898c6
parent0fd8d7970b1bc0fa318a7db65f2e10f097f593de (diff)
downloadnative-23c30e9e86e097695a2237cbe482c78d6d5ed076.tar.gz
libbinder_ndk: clarify error prune functions
libbinder_ndk has some functionality to prevent unknown errors from propagating out of an NDK API, but these error messages didn't clearly indicate that the number they were printing is the unknown error value, not the value the error is changed to. Bug: 166822339 Test: N/A Change-Id: I54a8aa22413cb5b32f2a75e84ddaeb05fc378b9e
-rw-r--r--libs/binder/ndk/status.cpp8
1 files changed, 4 insertions, 4 deletions
diff --git a/libs/binder/ndk/status.cpp b/libs/binder/ndk/status.cpp
index 87e1341f36..d889593474 100644
--- a/libs/binder/ndk/status.cpp
+++ b/libs/binder/ndk/status.cpp
@@ -123,8 +123,8 @@ binder_status_t PruneStatusT(status_t status) {
return STATUS_UNKNOWN_ERROR;
default:
- LOG(WARNING) << __func__
- << ": Unknown status_t pruned into STATUS_UNKNOWN_ERROR: " << status;
+ LOG(WARNING) << __func__ << ": Unknown status_t (" << status
+ << ") pruned into STATUS_UNKNOWN_ERROR";
return STATUS_UNKNOWN_ERROR;
}
}
@@ -155,8 +155,8 @@ binder_exception_t PruneException(int32_t exception) {
return EX_TRANSACTION_FAILED;
default:
- LOG(WARNING) << __func__
- << ": Unknown status_t pruned into EX_TRANSACTION_FAILED: " << exception;
+ LOG(WARNING) << __func__ << ": Unknown binder exception (" << exception
+ << ") pruned into EX_TRANSACTION_FAILED";
return EX_TRANSACTION_FAILED;
}
}