Age | Commit message (Collapse) | Author |
|
Change-Id: I01d9207b01534712c350b7338c892dc2d6a42508
|
|
Prior to this change, native work sources didn't read or write any
information concerning WorkChains, but Java ones did. This lead to a
mismatch when Java code, such as PowerManagerService, unparceled the
WorkSource as it read the whatever the next 4 bytes happened to be as
the WorkChain count, but it was actually reading whatever the next item
in the transaction happened to have written.
Note that this change does _not_ attempt to add a WorkChain
implementation to native. It instead makes it so that WorkSources
written from native to Java, or Java to native with no WorkChains, are
correctly and symmetrically parceled. In addition, if a Java WorkSource
is sent to native with a non-zero amount of WorkChains associated, then
it will return an error when unparceling rather than continuing but
leaving in the Parcel in an undefined state.
Bug: 234429395
Test: atest WorkSourceTest.cpp
Test: Write sample native app that grabs wakelock, validate display ID
Change-Id: Id1a5f29f4ccf2996e37ec99014ce392599b6b725
(cherry picked from commit c1359ac51c970666691ef4d07a6969c434062037)
Merged-In: Id1a5f29f4ccf2996e37ec99014ce392599b6b725
|
|
Change-Id: Ieccad3a1ea9fd1e658a4500e2c069347e9385b8c
|
|
Starting a few weeks ago a crop of issues started showing up
on a subset of devices, related to the early release optimization
(which landed much earlier). Attempts to fix them unfortunately introduced
another regression. The fact that the optimization is only triggering
visible errors on a subset of devices is somewhat of a mystery. A CL
is prepared which fixes all issues observed to date.
Howeverthis mystery about device specific behavior implies the full
implications of the optimization are not yet understood. It's better
to disable the optimization for the current release and take time to
fully understand what is happening. Removing the optimization may have
some impact on jank, but I expect it's unlikely to be large.
I only expect the optimization to reduce jank in cases
where:
1. The app is backpressured
2. SurfaceFlinger is repeatedly missing frames producing long
dequeues
3. The app has UI + RenderThread time >= vsync interval and is
only able to achieve steady production with render ahead and
pipelining.
If SurfaceFlinger were to begin regular frame production again, early
release could help the steady production pipeline recover faster by
unblocking the app sooner. This represents a small amount of edge cases.
Continued work on preventing SF from missing frames, makes this probably
even a smaller amount than when the early release optimization first
landed.
Bug: 236120925
Bug: 234753489
Test: Existing tests pass. Verify that early release is disabled.
Change-Id: I6a9a34331edb752d51c9d2d0b6826942d0545e3d
(cherry picked from commit b645049d01ef72653dc8fc363b9af18f4678f1e8)
Merged-In: I6a9a34331edb752d51c9d2d0b6826942d0545e3d
|
|
Change-Id: I31638619ac5ce36967c9ab9aec04f8fe501943df
|
|
|
|
Enable ATRACE logging from VsyncSchedule.cpp which is needed for debugging.
Test: collect systraces with debug.sf.show_predicted_vsync set to true
and observe VSYNC-predicted track
Change-Id: Id23fa2f0004319f4ee592e19dc34a6b74cdb644f
Bug: 235566681
|
|
It was found that the persistent rss_stat_throttled event trigger
causes a 8% incease in kswapd CPU usage. So remove this persistent
trigger, instead perfetto will dynamically create the trigger when
needed.
Test: adb push test/configs/rss_stat.cfg /data/local/tmp/
&& cf-adb shell 'cat /data/local/tmp/rss_stat.cfg |
perfetto --txt -c - -o /data/misc/perfetto-traces/trace
Bug: 236172293
Change-Id: I70a978de1fbf2ed538bb869edc715e61aee7efa4
Merged-In: I70a978de1fbf2ed538bb869edc715e61aee7efa4
|
|
Change-Id: I4ea732e514457b66687b90ee4791bd52de874cc5
|
|
When applying a transform to a Region, if the Region is translated to
bounds that overlow the int32_t type, the process crashes.
For now, we guard against process crashes by manually applying the
offset to the Region and checking for overflows. If we detect an
overflow in one of the Rects in a Region, we remove the Rect from the
resulting Region.
Bug: 234247210
Test: atest libgui_test
Change-Id: Icd47539accae2e59a7dbd9c9621201bd040fc402
|
|
Change-Id: Ibeadf7a3d730397c04e685a4692a4f3d8bab896f
|
|
Change-Id: Iede7b49a07d5672cf78b75c969b75f9e8d270ab6
|
|
(fixes 32-bit arch)
Bug: 235386871
Test: TreeHugger
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I9c37483eca17011f3f6d9755427c5a380166228e
|
|
|
|
Change-Id: I10bd369fe526e90f9354b243e45aa716b45f81c5
|
|
condition in stealReceiveChannel am: 0840cdd08f am: 544a3eb0bd -s ours am: c9aeff39f4 -s ours am: 5f4769af2d -s ours am: 1d5757d322 -s ours am: 1c4c580e1e -s ours am: 0dfd3dfa51 -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766212
Change-Id: I6cb864eea0b1f241073bb7c973100c10c7d66126
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
condition in stealReceiveChannel am: 0840cdd08f am: 544a3eb0bd -s ours am: c9aeff39f4 -s ours am: 5f4769af2d -s ours am: 1d5757d322 -s ours am: 196cc7c7fa -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766212
Change-Id: If37c5d3c76f400c021c0ee4d449de8ecc5943f88
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
condition in stealReceiveChannel am: 0840cdd08f am: 544a3eb0bd -s ours am: c9aeff39f4 -s ours am: 5f4769af2d -s ours am: 1d5757d322 -s ours am: 1c4c580e1e -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766212
Change-Id: Ida5f3fc2eda01277a07085af996147ee660c1ac1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
condition in stealReceiveChannel am: 0840cdd08f am: 544a3eb0bd -s ours am: c9aeff39f4 -s ours am: 5f4769af2d -s ours am: 1d5757d322 -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766212
Change-Id: I76aca60d8fb39ddf5d2f447381b8fc64102c4491
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
condition in stealReceiveChannel am: 0840cdd08f am: 544a3eb0bd -s ours am: c9aeff39f4 -s ours am: 5f4769af2d -s ours am: 1d5757d322 -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766212
Change-Id: Ib4c77eb41feed6abb9d6fdd2ee3b8dd10c6ff281
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
condition in stealReceiveChannel am: a820057ae0 am: 68ac61d494 -s ours am: 61bcc6eccb -s ours am: f50112a1c1 -s ours am: b5e14d7c1f -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766123
Change-Id: I479b3776fa99a6f801ce3da4b44666f20d47c407
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
condition in stealReceiveChannel am: 0840cdd08f am: 544a3eb0bd -s ours am: c9aeff39f4 -s ours am: 5f4769af2d -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766212
Change-Id: If141f433a79f656647cdbc5f785c0b43666d71a9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
condition in stealReceiveChannel am: 067def0585 -s ours am: 3102f9b9ab -s ours am: 210d52c18c -s ours am: 29ee7fa7e5 -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766116
Change-Id: I845b5e2e6b922a8e397ceab11c1bf793c517cf3f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
condition in stealReceiveChannel am: a820057ae0 am: 68ac61d494 -s ours am: 61bcc6eccb -s ours am: f50112a1c1 -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766123
Change-Id: I210a40eaccee6c545be2397155857bffd5c80028
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
condition in stealReceiveChannel am: 067def0585 -s ours am: 3102f9b9ab -s ours am: 210d52c18c -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766116
Change-Id: I4894445528a948ff2b2032caf4a5c7a8b3b50832
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
condition in stealReceiveChannel am: 0840cdd08f am: 544a3eb0bd -s ours am: c9aeff39f4 -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766212
Change-Id: Ib29196382c66c2847cfa2e239da0ba18120e267a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
condition in stealReceiveChannel am: a820057ae0 am: 68ac61d494 -s ours am: 61bcc6eccb -s ours am: cb94dd4a8d -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766123
Change-Id: I02dbcf4da433d7a9696cb9527da4befe5bf1be56
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
condition in stealReceiveChannel am: 067def0585 -s ours am: 3102f9b9ab -s ours am: 25efcc1f5b -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766116
Change-Id: I2250743d7df7f7514a7e3e79583b46301cf79ddb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
potential race condition in stealReceiveChannel 2p: 29e34cfcf9 am: ce81f1fffa -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766107
Change-Id: Ib43ec873e0c9adb24c2276e277fcb98c0d4b37fe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
condition in stealReceiveChannel am: a820057ae0 am: 68ac61d494 -s ours am: 61bcc6eccb -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766123
Change-Id: Ic0283d70d1096d89084f2a73200a958d52b31e3d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
condition in stealReceiveChannel am: 067def0585 -s ours am: 3102f9b9ab -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766116
Change-Id: Ib77a37ca9f1c3e560849c5889ee9a321b2c25b41
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
condition in stealReceiveChannel am: a820057ae0 am: 68ac61d494 -s ours am: 61bcc6eccb -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766123
Change-Id: Ia0ed099e9d124a07be0476d113a98810659a91d0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
condition in stealReceiveChannel am: 067def0585 -s ours am: 3102f9b9ab -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766116
Change-Id: Ie66eb09532ea8d3e54a7e9ee75fcb56b84b914a9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
condition in stealReceiveChannel am: 0840cdd08f am: 544a3eb0bd -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766212
Change-Id: I24b0fa2120b7d94f97fb1c07b0793585e925643e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
potential race condition in stealReceiveChannel 2p: 29e34cfcf9 am: e434a7db4d -s ours am: 0f2516a285 -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766107
Change-Id: Ic734a77b44de79f0dba143698026c35706e2a953
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
potential race condition in stealReceiveChannel 2p: 29e34cfcf9 am: e434a7db4d -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766107
Change-Id: I28a041389544926985114725991dbda4d9a9e057
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
stealReceiveChannel am: 0840cdd08f
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766212
Change-Id: I4710ac999b560074a4cacbde6cf22ac1ad000e0d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
condition in stealReceiveChannel am: a820057ae0 am: 68ac61d494 -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766123
Change-Id: I8b541f37df0aded1e9e52c1bbb9ee2a642c833be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
condition in stealReceiveChannel am: 067def0585 -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766116
Change-Id: I2f355f97d14eeae82fef14c0728863eafbcf8e10
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
potential race condition in stealReceiveChannel" into sc-v2-dev am: 8762075bc1 -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18764133
Change-Id: I83fb90b98921155775bf6542891ebe30c9f5b890
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
condition in stealReceiveChannel am: 97a317064a -s ours
am skip reason: subject contains skip directive
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18764133
Change-Id: I4a41e3c3bd164769fef3a03b3abe9c033e707956
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
stealReceiveChannel am: a820057ae0
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766123
Change-Id: I2fa98134881d1d0cd6df6dc3c0d9d19ff9ad5dfd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
stealReceiveChannel" into sc-v2-dev
|
|
stealReceiveChannel
Add a mutex to prevent a potential race condition.
Bug: 232541124
Test: See bug for details
Change-Id: Ia338f124c786bf12d6adba10a67b9048fe9c34a5
|
|
stealReceiveChannel
Add a mutex to prevent a potential race condition.
Bug: 232541124
Test: See bug for details
Change-Id: Ia338f124c786bf12d6adba10a67b9048fe9c34a5
|
|
stealReceiveChannel
Add a mutex to prevent a potential race condition.
Bug: 232541124
Test: See bug for details
Change-Id: Ia338f124c786bf12d6adba10a67b9048fe9c34a5
|
|
stealReceiveChannel
Add a mutex to prevent a potential race condition.
Bug: 232541124
Test: See bug for details
Change-Id: Ia338f124c786bf12d6adba10a67b9048fe9c34a5
|
|
condition in stealReceiveChannel 2p: 29e34cfcf9
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766107
Bug: 232541124
Change-Id: Iac86443781ff38b899f95ed5b3777325fb8a962f
|
|
condition in stealReceiveChannel 2p: 29e34cfcf9
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/native/+/18766107
Bug: 232541124
Change-Id: I89aa3895c76578f2d67d9082dd2fe91cf029aaec
|
|
stealReceiveChannel
Add a mutex to prevent a potential race condition.
Bug: 232541124
Test: See bug for details
Change-Id: Ia338f124c786bf12d6adba10a67b9048fe9c34a5
|