Age | Commit message (Collapse) | Author |
|
into 24Q1-release.
Change-Id: I6e963816f63e55a07636c92962ae409edff22f9a
|
|
If a layer handle is destroyed before we commit any transactions, we
will not be able to promote the legacy layer object in the main thread. This
is a few of the remaining warts with the legacy frontend which we can fixed
once we remove the flag. For now, fix this by checking if the layer was
destroyed before accessing the legacy layer object.
Test: presubmit
Fixes: 318347070
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:1009dbdbbf28c891d70d9d125b081b3df4c5849d)
Merged-In: Ia54feb4b483f0981acd198a0af07745cec183863
Change-Id: Ia54feb4b483f0981acd198a0af07745cec183863
|
|
into 24Q1-release.
Change-Id: Ib75bc18824fdb205f0add1b9ee99bd7759a762aa
|
|
inputBoundsInDisplaySpace is already in display space so remove the
second call to transform the rect by the display transform.
This causes a bug if the layer is using layer crop for touchable region
and the display is rotated since the bounds will get double transformed,
causing the touchable region to be offscreen.
Bug: 312984511
Test: LayerSnapshotTest#CanCropTouchableRegionWithDisplayTransform
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:1ba381e89fe7dfa20b0c8c1a880af59e2698925a)
Merged-In: I7d3eb9d5f129988573907658795e3a4349a5ece9
Change-Id: I7d3eb9d5f129988573907658795e3a4349a5ece9
|
|
'googleplex-android-review.googlesource.com/25781673'] into 24Q1-release.
Change-Id: I10da613b9b37cefe00ff0ba787b3ef83799a3616
|
|
This reverts commit 027650fb9f4a54a1848f062e9944cd845651208d.
Ignore-AOSP-First: this is for 24q1-release
Bug: 317676192
Test: manual check (wifi hal service should work with U GSI)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:e40a10779c74290c504a38799f81eb6e0a06610d)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:fde6b58b4f9efb8998364f2bcfa51cc1c1e48834)
Merged-In: I0211eb1f7f8c74a43143cbed7c32c065eabf39ed
Change-Id: I0211eb1f7f8c74a43143cbed7c32c065eabf39ed
|
|
Bug: 313353712
Bug: 316517849
Bug: 296019634
Test: atest CtsDeqpTestCases -- --module-arg 'CtsDeqpTestCases:include-filter:dEQP-VK.wsi.*'
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:abab5a09b414afb9e9d21dfeb8a10c7ccb337d8c)
Merged-In: I0726b39aacaba87a531af9bef23c8a214bc38425
Change-Id: I0726b39aacaba87a531af9bef23c8a214bc38425
|
|
'googleplex-android-review.googlesource.com/25755039', 'googleplex-android-review.googlesource.com/25756123'] into 24Q1-release.
Change-Id: If5cd3f0937b5e09cd8ce57765127f5d6a3d07b88
|
|
Revert submission 25624362-persistable-bundle-hack
Reason for revert: Likely culprit for b/317912559
Reverted changes: /q/submissionid:25624362-persistable-bundle-hack
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:027650fb9f4a54a1848f062e9944cd845651208d)
Merged-In: Ifa4d8c849b4f1a7a8ade6592c073dc6c81d0a85c
Change-Id: Ifa4d8c849b4f1a7a8ade6592c073dc6c81d0a85c
|
|
The "pruning input queue" functionality is present in order to prevent
the dispatcher from being blocked. However, only focus-dispatched events
(like keys and joystick events) can block the dispatcher, because they
require a focused window. Pointer events, like touches, go to the
touched window, and are not blocked.
Furthermore, dropping pointer events is not a good idea, because it can
cause inconsistent input streams to be processed inside the dispatcher.
In this CL, we prevent pointer events from being dropped. This resolves
a crash in InputDispatcher, because an inconsistent input stream would
lead to unexpected behaviour later on in the pipeline.
To reproduce the original crash:
1) Set device to 3-button navigation mode
2) Launch an app, then quickly press the back button
3) Then, quickly touch the app again
The WM would not yet send the "setFocusedApplication" call to match the
newly launched app (maybe it's slow, or it's just a bug). The dispatcher
would be waiting for a focused window, and the touch into the newly
launched app would cause the dispatcher to drop events because "the user
is interacting with a different app than the one that's currently
focused". And finally, since the navigation bar listens for outside
touches, the dispatcher would try to send an ACTION_OUTSIDE event to the
navigation bar, and this would conflict with the current dispatcher
state because there's already a pointer inside navigation bar (and the
dispatcher dropped the ACTION_UP event instead of processing it).
Bug: 308531018
Test: TEST=inputflinger_tests; m $TEST && $ANDROID_HOST_OUT/nativetest64/$TEST/$TEST
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:99e407b0e7e748cbb82bdaa2e21c740c308d60b3)
Merged-In: I7ac5f7bd607c7411e3917977888d1cfeaf96615c
Change-Id: I7ac5f7bd607c7411e3917977888d1cfeaf96615c
|
|
This behaviour causes InputDispatcher to drop input events, potentially
leading to incorrect input event streams inside the dispatcher.
This later causes a crash.
This behaviour is no longer needed, so we should remove it.
In the future, all of the related code should be deleted, as well.
Bug: 308531018
Test: none
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:18a1d513e965c406c106993fc52c74618a4c3205)
Merged-In: I32dcfae512e84d3d7a3ada76b826c84269ef6075
Change-Id: I32dcfae512e84d3d7a3ada76b826c84269ef6075
|
|
into 24Q1-release.
Change-Id: Ia86eaa58a2d3cbcec5ce55f5874d1245eb5007f7
|
|
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:85a8ae132ee2d4da024a69a7c1bcfa8e33e5357f)
Merged-In: I2b0ed90b1526e579ae4edb6d62ad58370ac8a5c6
Change-Id: I2b0ed90b1526e579ae4edb6d62ad58370ac8a5c6
|
|
into 24Q1-release.
Change-Id: Id481c5441b298375977ef5519552b3c6484ca755
|
|
This reverts commit f8d9e440558f4dfb13ef41e23f41f30092297582.
Reason for revert: b/316593362
Test: atest inputflinger_tests
Bug: b/316593362
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4bb0bd5eb22f87c7c39a982bc4a7e6826f224383)
Merged-In: Idfbf2091febba12c0e92a39bedb56b1058b85047
Change-Id: Idfbf2091febba12c0e92a39bedb56b1058b85047
|
|
sparse-11231981-L99300030000917396 into 24Q1-release.
COASTGUARD_SKIP: Ifeb8f30b90aea17c62bc5d315ecc62ac21fe7bfe
COASTGUARD_SKIP: Idfbf2091febba12c0e92a39bedb56b1058b85047
Change-Id: Ibc673d4c9431f0bae5c8372df9c34e7ebe7a4e7f
|
|
into sparse-11231981-L99300030000917396.
SPARSE_CHANGE: Idfbf2091febba12c0e92a39bedb56b1058b85047
Change-Id: Ifeb8f30b90aea17c62bc5d315ecc62ac21fe7bfe
|
|
This reverts commit f8d9e440558f4dfb13ef41e23f41f30092297582.
Reason for revert: b/316593362
Test: atest inputflinger_tests
Bug: b/316593362
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4bb0bd5eb22f87c7c39a982bc4a7e6826f224383)
Merged-In: Idfbf2091febba12c0e92a39bedb56b1058b85047
Change-Id: Idfbf2091febba12c0e92a39bedb56b1058b85047
|
|
Change-Id: I3187bdc28d220b3de2813d978684f2a2aa593140
|
|
|
|
|
|
330be7fa00 am: 0a21341999 am: 0b3aa54af9
Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/2869276
Change-Id: Iccde558340a9f9f6ae3ddfd8c9cc55d544ef136a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
330be7fa00 am: 0a21341999
Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/2869276
Change-Id: I11c3b87cad521a7aedc99a52bdbc024752687434
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Bug: 316224736
Change-Id: I264e728c49f0500f2f868c3a25b0910d0d527340
Test: presubmit
|
|
Change-Id: Ib0a1981e1c53a850d3d9143b010d945e42e41aee
|
|
330be7fa00
Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/2869276
Change-Id: I9ab01d3f7a9fe7db629ab48d05a6280b43c4528e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
|
|
This moves the notifyExpectedPresent call off the HWComposer,
HWComposer should only be access with mStateLock or from the main
thread, and moving this to SF achieves that.
Schedule the HWComposer::notifyExpectedPresent
call on the main thread once the decision to
send the hint is made
BUG: 311300327
Test: atest
Change-Id: Ia5f92546028ce104e391364c6696415c29760232
|
|
|
|
into main
|
|
|
|
Similar fix to
https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4996084
Bug: 308807804
Test: m inputflinger_tests
Change-Id: I84d0fdf2339cbdc0dead03d56f939d6808792213
|
|
Test: presubmit
Change-Id: I72a7d888cbaee4dd782ec43c1fc130669d9eb2ac
|
|
This CL adds the SurfaceFlinger side code for supporting the new
batched commands for createLayer/DestroyLayer.
Bug: 290685621
Test: atest VtsHalGraphicsComposer3_TargetTest
atest PerInstance/GraphicsComposerAidlBatchedCommandTest
Change-Id: I1793bda0a1eac1c2cecd0c6ab00d5df9fd8d6d0a
|
|
|
|
|
|
ftl::Function<F, N> is a container for function object, and can mostly
be used in place of std::function<F>.
Unlike std::function<F>, a ftl::Function<F, N>:
* Uses a static amount of memory (controlled by N), and never any
dynamic allocation.
* Satisfies the std::is_trivially_copyable<> trait.
* Satisfies the std::is_trivially_destructible<> trait.
However to satisfy those constraints, the contained function object must
also satisfy those constraints, meaning certain types (like
std::unique_ptr's) cannot be part of the contained function object type.
The size of a ftl::Function<F, N> is guaranteed to be:
sizeof(std::intptr_t) * (N + 2)
If not specified, N defaults to zero, which is big enough to store a lambda
that captures a single pointer (such as "this" for forwarding to a
member function.
By comparison, sizeof(std::function) == sizeof(std::intptr_t) * 4, at
least with on x86-64 with clang 15.
Compile time checks are performed that the constraints are all satisfied,
and that the value of N is large enough to contain the desired function
object type.
ftl::make_function is a helper function to construct a ftl::Function,
and will deduce the template type arguments. In addition to constructing
a ftl::Function for a function object, ftl::make_function has overloads
for creating a ftl::Function which will invoke a member function or a free
(non-member) function.
ftl::no_op is a helper value to construct a ftl::Function<F, N> that
does nothing, except default construct a return value, if one is needed.
A unit test is also included to demonstrate and verify the
implementation, including asserting that function objects which don't
meet the requirements cannot be used. The test also asserts some
non-obvious corner cases for handling argument and return value
conversions to match how std::function behaves.
Bug: 279581095
Test: atest ftl_test
Change-Id: I268facb106a248d0766e931595291036bc606fb7
|
|
Change-Id: I17fa6c458bc47c7624cab6fe2a09be7153b95759
|
|
am: 2418e798db
Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/2585152
Change-Id: I2cce10a1fee806c7bb51e11c77f47f33e2e1ae56
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
am: 15823bcf08 am: 066748effb am: 9f8d0e7205
Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/2584789
Change-Id: I3ec257e368d1f08433984aaed4cd4d9a41664964
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
7073b23935 am: c860791d94
Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/2871055
Change-Id: I0ee2e54a73552e40e05b88eefab8772ca6af04d1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Add functionality of scrambling windows for the dispatcher fuzzer.
This allows greater coverage of the dispatcher code.
Also, skip events with ACTION_SCROLL because they might contain an
invalid number of pointers, and they won't correctly be rejected because
we aren't verifying them right now.
Bug: 287342122
Test: FUZZER=inputflinger_input_dispatcher_fuzzer; m $FUZZER && ASAN_OPTIONS=detect_odr_violation=0 $ANDROID_HOST_OUT/fuzz/x86_64/$FUZZER/$FUZZER
Change-Id: I6715ee0327cb5cde76996f1c6a80ceba15030aef
|
|
connected" into main
|
|
Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/2585152
Change-Id: I8ea414af696ff27b9173e844457988289831373a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
am: 15823bcf08 am: 066748effb
Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/2584789
Change-Id: Ie5e0c9c69fe650ed664048e03f3aae4c65aae2d6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/2871055
Change-Id: Ib8e91977d577cbee6c3cd0c998de2880497bca89
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/2585152
Change-Id: Ie8038d10b194f64cc05a398e1b512c78a78f5c63
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
am: 15823bcf08
Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/2584789
Change-Id: I64547d79ca89c6f4e3e0599f0f83da087b4bb961
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/2871055
Change-Id: I80e30a9c1641e4d396b4a6dc0468d74fe429228b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
40629347f6 am: 8e68dda5eb am: 54206636da
Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/2862764
Change-Id: I7c5cf1eb6a248c57bc5a1d47539584a4dd00d9d2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|