summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMikhail Naganov <mnaganov@google.com>2020-03-26 13:18:12 -0700
committerMikhail Naganov <mnaganov@google.com>2020-03-26 13:18:12 -0700
commit1d08a56cff05d38f4989caf7ba1a2bd3a95b5336 (patch)
treeaf285407004295d2ee89b7b0a7c9b20536b424f5
parentde4d82fc16c848733df1f35c5969a771f06a888b (diff)
downloadlibhardware-1d08a56cff05d38f4989caf7ba1a2bd3a95b5336.tar.gz
usbaudio: Add missing 'return' on error
Code in adev_open_input_stream was deallocating a structure but then using it again due to absence of a 'return' statement. Found by clang-tidy. Bug: 152526318 Test: m Change-Id: I9ec3148197715fb118e99503d2b52412a4fb2a73
-rw-r--r--modules/usbaudio/audio_hal.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/modules/usbaudio/audio_hal.c b/modules/usbaudio/audio_hal.c
index f0ea015a..a19a0ae3 100644
--- a/modules/usbaudio/audio_hal.c
+++ b/modules/usbaudio/audio_hal.c
@@ -1142,6 +1142,7 @@ static int adev_open_input_stream(struct audio_hw_device *hw_dev,
// adev_close_input_stream() in this case.
*stream_in = NULL;
free(in);
+ return ret;
}
device_lock(in->adev);