diff options
author | sirius.wang <sirius.wang@mediatek.corp-partner.google.com> | 2020-08-28 16:28:24 +0000 |
---|---|---|
committer | Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> | 2020-08-28 16:28:24 +0000 |
commit | 224d06fa1aba71a08220082f212d76a89d568bf6 (patch) | |
tree | 6160a0766fbbfb1f3eac1cd1769b4650eead51d2 | |
parent | 7cb8fd1b654b65c1ea8dbd14b408951224f42d42 (diff) | |
parent | 9c2f03b90646343e7e379cdcdf0f4d8c1e7a33a6 (diff) | |
download | core-224d06fa1aba71a08220082f212d76a89d568bf6.tar.gz |
fuzzy_fastboot: use 'tcp:' prefix to identify fastboot protocol. am: 767fe1515a am: 9c2f03b906
Original change: https://googleplex-android-review.googlesource.com/c/platform/system/core/+/12448097
Change-Id: I82069a7f289a340351280bb18cd5af8ffa6f01b1
-rw-r--r-- | fastboot/fuzzy_fastboot/fixtures.cpp | 25 |
1 files changed, 10 insertions, 15 deletions
diff --git a/fastboot/fuzzy_fastboot/fixtures.cpp b/fastboot/fuzzy_fastboot/fixtures.cpp index bd76ff4ee..9b5e5f7bd 100644 --- a/fastboot/fuzzy_fastboot/fixtures.cpp +++ b/fastboot/fuzzy_fastboot/fixtures.cpp @@ -45,6 +45,7 @@ #include <vector> #include <android-base/stringprintf.h> +#include <android-base/strings.h> #include <gtest/gtest.h> #include "fastboot_driver.h" @@ -76,8 +77,7 @@ int FastBootTest::MatchFastboot(usb_ifc_info* info, const std::string& local_ser } bool FastBootTest::IsFastbootOverTcp() { - // serial contains ":" is treated as host ip and port number - return (device_serial.find(":") != std::string::npos); + return android::base::StartsWith(device_serial, "tcp:"); } bool FastBootTest::UsbStillAvailible() { @@ -182,19 +182,14 @@ void FastBootTest::TearDownSerial() { } void FastBootTest::ConnectTcpFastbootDevice() { - std::size_t found = device_serial.find(":"); - if (found != std::string::npos) { - for (int i = 0; i < MAX_TCP_TRIES && !transport; i++) { - std::string error; - std::unique_ptr<Transport> tcp( - tcp::Connect(device_serial.substr(0, found), tcp::kDefaultPort, &error) - .release()); - if (tcp) - transport = - std::unique_ptr<TransportSniffer>(new TransportSniffer(std::move(tcp), 0)); - if (transport != nullptr) break; - std::this_thread::sleep_for(std::chrono::milliseconds(10)); - } + for (int i = 0; i < MAX_TCP_TRIES && !transport; i++) { + std::string error; + std::unique_ptr<Transport> tcp( + tcp::Connect(device_serial.substr(4), tcp::kDefaultPort, &error).release()); + if (tcp) + transport = std::unique_ptr<TransportSniffer>(new TransportSniffer(std::move(tcp), 0)); + if (transport != nullptr) break; + std::this_thread::sleep_for(std::chrono::milliseconds(10)); } } |