summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorandroid-build-prod (mdb) <android-build-team-robot@google.com>2020-06-09 09:59:16 +0000
committerGerrit Code Review <noreply-gerritcodereview@google.com>2020-06-09 09:59:16 +0000
commita77b2de1df65919d3ec1777d640f612918430590 (patch)
tree2522f47fba601ff8930b72aa1a925ae27925779c
parent61a0c8416ef08048d630521c4cbadfe3374044d7 (diff)
parent20af06cb4de159cc7f4f79dec2a9b3f695319d17 (diff)
downloadcore-a77b2de1df65919d3ec1777d640f612918430590.tar.gz
Merge "Merge cherrypicks of [1326087, 1326294] into sdk-release" into sdk-release
-rw-r--r--adb/client/incremental.cpp13
1 files changed, 9 insertions, 4 deletions
diff --git a/adb/client/incremental.cpp b/adb/client/incremental.cpp
index a8b0ab3d0..897c7e5de 100644
--- a/adb/client/incremental.cpp
+++ b/adb/client/incremental.cpp
@@ -164,7 +164,7 @@ std::optional<Process> install(const Files& files, const Args& passthrough_args,
int print_fds[2];
if (adb_socketpair(print_fds) != 0) {
if (!silent) {
- fprintf(stderr, "Failed to create socket pair for child to print to parent\n");
+ fprintf(stderr, "adb: failed to create socket pair for child to print to parent\n");
}
return {};
}
@@ -191,10 +191,15 @@ std::optional<Process> install(const Files& files, const Args& passthrough_args,
Result result = wait_for_installation(pipe_read_fd);
adb_close(pipe_read_fd);
- if (result == Result::Success) {
- // adb client exits now but inc-server can continue
- serverKiller.release();
+ if (result != Result::Success) {
+ if (!silent) {
+ fprintf(stderr, "adb: install command failed");
+ }
+ return {};
}
+
+ // adb client exits now but inc-server can continue
+ serverKiller.release();
return child;
}