summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYabin Cui <yabinc@google.com>2020-04-07 17:36:56 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2020-04-07 17:36:56 +0000
commitd72731a4f25d0732d0c3408f40a3622f95fb43fa (patch)
tree6b6c42e543d0d9a33efdb555a234a7dd1425e4d9
parent51160c72c4daa671fbd8fb20a226ab5e2f7a67ec (diff)
parent80cd87a60222701044f423f1f8e0fef8672a851c (diff)
downloadextras-d72731a4f25d0732d0c3408f40a3622f95fb43fa.tar.gz
simpleperf: fix CanRecordRawData. am: bcf045413b am: 80cd87a602
Change-Id: I4a3957100dfb9e0e1ed8cc17170a2dfa92783163
-rw-r--r--simpleperf/environment.cpp17
1 files changed, 7 insertions, 10 deletions
diff --git a/simpleperf/environment.cpp b/simpleperf/environment.cpp
index e16e496f..5b2fcaa8 100644
--- a/simpleperf/environment.cpp
+++ b/simpleperf/environment.cpp
@@ -299,18 +299,15 @@ bool CanRecordRawData() {
if (IsRoot()) {
return true;
}
- int value;
- if (!ReadPerfEventParanoid(&value) || value > -1) {
- return false;
- }
#if defined(__ANDROID__)
- // If perf_event_open() is controlled by selinux, simpleperf can't record tracepoint raw data
- // unless running as root.
- if (android::base::GetProperty("sys.init.perf_lsm_hooks", "") == "1") {
- return false;
- }
+ // Android R uses selinux to control perf_event_open. Whether raw data can be recorded is hard
+ // to check unless we really try it. And probably there is no need to record raw data in non-root
+ // users.
+ return false;
+#else
+ int value;
+ return ReadPerfEventParanoid(&value) && value == -1;
#endif
- return true;
}
static const char* GetLimitLevelDescription(int limit_level) {