summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYabin Cui <yabinc@google.com>2015-12-09 03:31:51 +0000
committerGerrit Code Review <noreply-gerritcodereview@google.com>2015-12-09 03:31:51 +0000
commit4818f026d4c35683222b84976de17da18ae178bb (patch)
treefef75a726edd2f345c5d188d85433338ee25baa9
parent95c06b156fd8008b74eac9720f933f479f84a340 (diff)
parenta5b79fd2c1a255f587859621094c50882ea8c8d1 (diff)
downloadextras-4818f026d4c35683222b84976de17da18ae178bb.tar.gz
Merge "Simpleperf: check value returned by fopen."
-rw-r--r--simpleperf/read_elf.cpp5
1 files changed, 4 insertions, 1 deletions
diff --git a/simpleperf/read_elf.cpp b/simpleperf/read_elf.cpp
index 4774ea3f..a7399ce5 100644
--- a/simpleperf/read_elf.cpp
+++ b/simpleperf/read_elf.cpp
@@ -46,7 +46,10 @@ bool IsValidElfPath(const std::string& filename) {
if (!IsRegularFile(filename)) {
return false;
}
- FILE* fp = fopen(filename.c_str(), "rb");
+ FILE* fp = fopen(filename.c_str(), "reb");
+ if (fp == nullptr) {
+ return false;
+ }
char buf[4];
if (fread(buf, 4, 1, fp) != 1) {
fclose(fp);