Fixed buffer overflow in procrank.

If there are more than 256 processes in the system procrank
will overflow the procs array. Switched to heap allocation.

Change-Id: I05223333d31f669c6ac87577671e301e6d05c682

1 files changed, 7 insertions, 3 deletions

diff --git a/procrank/procrank.c b/procrank/procrank.c
index 585fddcd..bd5192d2 100644
--- a/procrank/procrank.c
+++ b/procrank/procrank.c
@@ -43,13 +43,11 @@ declare_sort(uss);
 int (*compfn)(const void *a, const void *b);
 static int order;
 
-#define MAX_PROCS 256
-
 int main(int argc, char *argv[]) {
     pm_kernel_t *ker;
     pm_process_t *proc;
     pid_t *pids;
-    struct proc_info *procs[MAX_PROCS];
+    struct proc_info **procs;
     size_t num_procs;
     char cmdline[256];
     int error;
@@ -92,6 +90,12 @@ int main(int argc, char *argv[]) {
         exit(EXIT_FAILURE);
     }
 
+    procs = malloc(num_procs * sizeof(struct proc_info*));
+    if (!procs) {
+        fprintf(stderr, "malloc: %s\n", strerror(errno));
+        exit(EXIT_FAILURE);
+    }
+
     for (i = 0; i < num_procs; i++) {
         procs[i] = malloc(sizeof(struct proc_info));
         if (!procs[i]) {