diff options
| author | Jean-Baptiste Queru <jbq@google.com> | 2012-08-09 11:24:26 -0700 |
|---|---|---|
| committer | android code review <noreply-gerritcodereview@google.com> | 2012-08-09 11:24:27 -0700 |
| commit | 332e8babe350433b320efc9484f15a5dbdd8c68f (patch) | |
| tree | caebf789623cae0477565131ca5afd8467c9bf09 | |
| parent | 983ce5738cee0bf78b87d6274fe1387129768302 (diff) | |
| parent | 3f6dfd684dd9451dcc4c83c42068c20753147077 (diff) | |
| download | extras-332e8babe350433b320efc9484f15a5dbdd8c68f.tar.gz | |
Merge "Avoid dereferencing NULL pointer with memcmp in the test code."
| -rw-r--r-- | tests/bionic/libc/common/test_libgen.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/bionic/libc/common/test_libgen.c b/tests/bionic/libc/common/test_libgen.c index 4a2c29e2..fd85816e 100644 --- a/tests/bionic/libc/common/test_libgen.c +++ b/tests/bionic/libc/common/test_libgen.c @@ -76,7 +76,7 @@ test_basename_r(char* _input, const char* _expected_content, int _expected, c return; } } - else if ( memcmp( _buff, _expected_content, ret ) ) { + else if (_buff != NULL && memcmp( _buff, _expected_content, ret ) ) { fprintf(stderr, "KO: basename_r(\"%s\", <buff>, %d) returned \"%s\", expected \"%s\"\n", _input, _bufflen, _buff, _expected_content ); @@ -109,7 +109,7 @@ test_dirname_r(char* _input, const char* _expected_content, int _expected, ch return; } } - else if ( memcmp( _buff, _expected_content, ret ) ) { + else if (_buff != NULL && memcmp( _buff, _expected_content, ret ) ) { fprintf(stderr, "KO: dirname_r(\"%s\", <buff>, %d) returned \"%s\", expected \"%s\"\n", _input, _bufflen, _buff, _expected_content ); |