diff options
author | TreeHugger Robot <treehugger-gerrit@google.com> | 2018-05-23 21:33:55 +0000 |
---|---|---|
committer | Android (Google) Code Review <android-gerrit@google.com> | 2018-05-23 21:33:55 +0000 |
commit | 932eb00d242d4bbb8fedbf07fe8cefd7b4b70ac9 (patch) | |
tree | 0af6df937a0d8d2b372db6aa3c1c8ec1af437ab4 | |
parent | 27fdbce115dea066262333ef798980338a6d5c19 (diff) | |
parent | e1f6ad4630adeb5be74ad137a173b0f047bf9542 (diff) | |
download | extras-932eb00d242d4bbb8fedbf07fe8cefd7b4b70ac9.tar.gz |
Merge "Make logging much less verbose" into pi-devpie-dev
-rw-r--r-- | ext4_utils/ext4_crypt.cpp | 16 |
1 files changed, 9 insertions, 7 deletions
diff --git a/ext4_utils/ext4_crypt.cpp b/ext4_utils/ext4_crypt.cpp index bdf80b09..5ec8723b 100644 --- a/ext4_utils/ext4_crypt.cpp +++ b/ext4_utils/ext4_crypt.cpp @@ -76,21 +76,23 @@ bool e4crypt_is_native() { return !strcmp(value, "file"); } -static void log_lslr(const char* dirname) { - std::array<const char*, 3> argv = {"ls", "-lR", dirname}; +static void log_ls(const char* dirname) { + std::array<const char*, 3> argv = {"ls", "-laZ", dirname}; int status = 0; auto res = android_fork_execvp(argv.size(), const_cast<char**>(argv.data()), &status, false, true); if (res != 0) { - PLOG(ERROR) << "ls -lR " << dirname << "failed"; + PLOG(ERROR) << argv[0] << " " << argv[1] << " " << argv[2] << "failed"; return; } if (!WIFEXITED(status)) { - LOG(ERROR) << "ls -lR " << dirname << " did not exit normally, status: " << status; + LOG(ERROR) << argv[0] << " " << argv[1] << " " << argv[2] + << " did not exit normally, status: " << status; return; } if (WEXITSTATUS(status) != 0) { - LOG(ERROR) << "ls -lR " << dirname << " returned failure: " << WEXITSTATUS(status); + LOG(ERROR) << argv[0] << " " << argv[1] << " " << argv[2] + << " returned failure: " << WEXITSTATUS(status); return; } } @@ -201,7 +203,7 @@ static bool e4crypt_policy_get(const char *directory, char *policy, if (ioctl(fd, EXT4_IOC_GET_ENCRYPTION_POLICY, &eep) != 0) { PLOG(ERROR) << "Failed to get encryption policy for " << directory; close(fd); - log_lslr(directory); + log_ls(directory); return false; } close(fd); @@ -240,7 +242,7 @@ static bool e4crypt_policy_check(const char *directory, const char *policy, policy_to_hex(policy, policy_hex); LOG(ERROR) << "Found policy " << existing_policy_hex << " at " << directory << " which doesn't match expected value " << policy_hex; - log_lslr(directory); + log_ls(directory); return false; } LOG(INFO) << "Found policy " << existing_policy_hex << " at " << directory |