diff options
author | Jiakai Zhang <jiakaiz@google.com> | 2024-05-14 13:55:02 +0000 |
---|---|---|
committer | Treehugger Robot <android-test-infra-autosubmit@system.gserviceaccount.com> | 2024-05-14 15:04:24 +0000 |
commit | 31778a493a96b4382acff11b33a8c624d4f52045 (patch) | |
tree | 8310c3ca20a239bccf08dd7f272c28442abf002e | |
parent | fc6d2353e723184c5387c3cfabda8b4dc7dcf0c8 (diff) | |
download | art-31778a493a96b4382acff11b33a8c624d4f52045.tar.gz |
Fix PreRebootDexoptJobTest.testCancel.
Bug: 338786922
Change-Id: Ib894fb37eb852520aac2f8700c0073cc1150adc5
Test: Presubmit
-rw-r--r-- | libartservice/service/javatests/com/android/server/art/PreRebootDexoptJobTest.java | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/libartservice/service/javatests/com/android/server/art/PreRebootDexoptJobTest.java b/libartservice/service/javatests/com/android/server/art/PreRebootDexoptJobTest.java index ba4e7bab52..c555879792 100644 --- a/libartservice/service/javatests/com/android/server/art/PreRebootDexoptJobTest.java +++ b/libartservice/service/javatests/com/android/server/art/PreRebootDexoptJobTest.java @@ -199,11 +199,14 @@ public class PreRebootDexoptJobTest { }); var unused = mPreRebootDexoptJob.start(); - Future<Void> future = new CompletableFuture().runAsync( - () -> { mPreRebootDexoptJob.cancel(true /* blocking */); }); - dexoptCancelled.release(); + Future<Void> future = new CompletableFuture().runAsync(() -> { + mPreRebootDexoptJob.cancel(false /* blocking */); + dexoptCancelled.release(); + mPreRebootDexoptJob.cancel(true /* blocking */); + }); Utils.getFuture(future); - // Check that `cancel` is really blocking. + // Check that `cancel(true)` is really blocking. If it wasn't, the check below might still + // pass due to a race, but we would have a flaky test. assertThat(jobExited.tryAcquire()).isTrue(); } |