diff options
| author | Mauri de Souza Meneguzzo <mauri870@gmail.com> | 2024-05-09 19:08:14 +0000 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2024-05-14 20:26:09 +0000 |
| commit | 9c2f3a21352d1ff4e47776534e3f334b39ec0183 (patch) | |
| tree | 1368fd21678926d5c3030b9d6a878828363c2655 | |
| parent | 59e1219a5f3786e7011dc4816d0dbb09fee91bc8 (diff) | |
| download | golang-x-text-upstream-master.tar.gz | |
cmd/gotext: fix segfault in extract & rewrite commandsupstream-master
If extract or rewrite are called with no arguments it results in a
segmentation fault, since we dereference the out flag that was
not defined for these commands.
Fixes golang/go#62697
Change-Id: I697943b7c221431d0361bcec74c18183f6e141ea
GitHub-Last-Rev: 313ddfad2b9a43d4fbaa875fa4dd3110dcf38083
GitHub-Pull-Request: golang/text#46
Reviewed-on: https://go-review.googlesource.com/c/text/+/529255
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
| -rw-r--r-- | cmd/gotext/main.go | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/cmd/gotext/main.go b/cmd/gotext/main.go index ed0f7ec..5171eb1 100644 --- a/cmd/gotext/main.go +++ b/cmd/gotext/main.go @@ -48,11 +48,18 @@ func config() (*pipeline.Config, error) { if err != nil { return nil, wrap(err, "invalid srclang") } + + // Use a default value since rewrite and extract don't have an out flag. + genFile := "" + if out != nil { + genFile = *out + } + return &pipeline.Config{ SourceLanguage: tag, Supported: getLangs(), TranslationsPattern: `messages\.(.*)\.json$`, - GenFile: *out, + GenFile: genFile, Dir: *dir, }, nil } |