summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKenny Guy <kennyguy@google.com>2017-01-17 23:33:41 +0000
committerandroid-merger <android-merger@vpba3.mtv.corp.google.com>2017-01-23 11:38:51 -0800
commit8ca969a7e936a90c707cd9dce0af53fcb5566574 (patch)
tree2e5dfb59acd1e64bb4a6b17587a9f8bac872fae6
parent117a3269856f0cc08b6b67c842de9f9ca1ed0b59 (diff)
downloadbase-nougat-mr1.4-release.tar.gz
Fix issue with saving admins before finishing loading.android-7.1.1_r27nougat-mr1.4-release
Saving device policy managers settings to clear out password stats was happening before initializing mAdminList so could wipe active admins. Test: manual - flash with N2G05C add google account with dmagent flash wth this fix, check dmagent is still an active admin, reboot check admin is still active. Test: runtest -c com.android.server.devicepolicy.DevicePolicyManagerTest frameworks-services Bug: 34277435 Change-Id: I13660b47f30e9aba001eb13f2e457c3b3f36da3e (cherry picked from commit adbda7474cc1968b66e9948aee566dc346e71340) (cherry picked from commit f98ed6863a7f64c535a66006852a934b05d550bc)
-rw-r--r--services/devicepolicy/java/com/android/server/devicepolicy/DevicePolicyManagerService.java6
1 files changed, 3 insertions, 3 deletions
diff --git a/services/devicepolicy/java/com/android/server/devicepolicy/DevicePolicyManagerService.java b/services/devicepolicy/java/com/android/server/devicepolicy/DevicePolicyManagerService.java
index fbb865bc64a9..43168660a316 100644
--- a/services/devicepolicy/java/com/android/server/devicepolicy/DevicePolicyManagerService.java
+++ b/services/devicepolicy/java/com/android/server/devicepolicy/DevicePolicyManagerService.java
@@ -2498,14 +2498,14 @@ public class DevicePolicyManagerService extends IDevicePolicyManager.Stub {
// Ignore
}
+ // Generate a list of admins from the admin map
+ policy.mAdminList.addAll(policy.mAdminMap.values());
+
// Might need to upgrade the file by rewriting it
if (needsRewrite) {
saveSettingsLocked(userHandle);
}
- // Generate a list of admins from the admin map
- policy.mAdminList.addAll(policy.mAdminMap.values());
-
validatePasswordOwnerLocked(policy);
updateMaximumTimeToLockLocked(userHandle);
updateLockTaskPackagesLocked(policy.mLockTaskPackages, userHandle);