diff options
Diffstat (limited to 'fs_mgr/libsnapshot/include/libsnapshot/snapshot_writer.h')
-rw-r--r-- | fs_mgr/libsnapshot/include/libsnapshot/snapshot_writer.h | 17 |
1 files changed, 2 insertions, 15 deletions
diff --git a/fs_mgr/libsnapshot/include/libsnapshot/snapshot_writer.h b/fs_mgr/libsnapshot/include/libsnapshot/snapshot_writer.h index 545f1171d..bf5ce8bb5 100644 --- a/fs_mgr/libsnapshot/include/libsnapshot/snapshot_writer.h +++ b/fs_mgr/libsnapshot/include/libsnapshot/snapshot_writer.h @@ -47,7 +47,6 @@ class ISnapshotWriter : public ICowWriter { virtual bool InitializeAppend(uint64_t label) = 0; virtual std::unique_ptr<FileDescriptor> OpenReader() = 0; - virtual bool VerifyMergeOps() const noexcept = 0; protected: android::base::borrowed_fd GetSourceFd(); @@ -59,7 +58,7 @@ class ISnapshotWriter : public ICowWriter { }; // Send writes to a COW or a raw device directly, based on a threshold. -class CompressedSnapshotWriter final : public ISnapshotWriter { +class CompressedSnapshotWriter : public ISnapshotWriter { public: CompressedSnapshotWriter(const CowOptions& options); @@ -71,26 +70,21 @@ class CompressedSnapshotWriter final : public ISnapshotWriter { bool Finalize() override; uint64_t GetCowSize() override; std::unique_ptr<FileDescriptor> OpenReader() override; - bool VerifyMergeOps() const noexcept; protected: bool EmitCopy(uint64_t new_block, uint64_t old_block) override; bool EmitRawBlocks(uint64_t new_block_start, const void* data, size_t size) override; - bool EmitXorBlocks(uint32_t new_block_start, const void* data, size_t size, uint32_t old_block, - uint16_t offset) override; bool EmitZeroBlocks(uint64_t new_block_start, uint64_t num_blocks) override; bool EmitLabel(uint64_t label) override; - bool EmitSequenceData(size_t num_ops, const uint32_t* data) override; private: - std::unique_ptr<CowReader> OpenCowReader() const; android::base::unique_fd cow_device_; std::unique_ptr<CowWriter> cow_; }; // Write directly to a dm-snapshot device. -class OnlineKernelSnapshotWriter final : public ISnapshotWriter { +class OnlineKernelSnapshotWriter : public ISnapshotWriter { public: OnlineKernelSnapshotWriter(const CowOptions& options); @@ -104,18 +98,11 @@ class OnlineKernelSnapshotWriter final : public ISnapshotWriter { uint64_t GetCowSize() override { return cow_size_; } std::unique_ptr<FileDescriptor> OpenReader() override; - // Online kernel snapshot writer doesn't care about merge sequences. - // So ignore. - bool VerifyMergeOps() const noexcept override { return true; } - protected: bool EmitRawBlocks(uint64_t new_block_start, const void* data, size_t size) override; bool EmitZeroBlocks(uint64_t new_block_start, uint64_t num_blocks) override; - bool EmitXorBlocks(uint32_t new_block_start, const void* data, size_t size, uint32_t old_block, - uint16_t offset) override; bool EmitCopy(uint64_t new_block, uint64_t old_block) override; bool EmitLabel(uint64_t label) override; - bool EmitSequenceData(size_t num_ops, const uint32_t* data) override; private: android::base::unique_fd snapshot_fd_; |