Use -Werror in system/extras

* Use system-extras-cflags-defaults
* Move -Wall -Werror from cppflags to cflags
* fix warning on redefinition of MAX_PATH

Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: Ib14b4d8eece767225a6fef639ed190b343678c00

1 files changed, 8 insertions, 6 deletions

diff --git a/f2fs_utils/Android.bp b/f2fs_utils/Android.bp
index 86790c4b..c2e6ebab 100644
--- a/f2fs_utils/Android.bp
+++ b/f2fs_utils/Android.bp
@@ -2,6 +2,7 @@
 
 cc_library_host_static {
     name: "libf2fs_utils_host",
+    defaults: ["system-extras-cflags-defaults"],
 
     srcs: ["f2fs_utils.c"],
 
@@ -15,8 +16,6 @@ cc_library_host_static {
         "external/f2fs-tools/mkfs",
     ],
 
-    cflags: ["-Wno-unused-parameter"],
-
     target: {
         darwin: {
             enabled: false,
@@ -26,6 +25,7 @@ cc_library_host_static {
 
 cc_library_host_static {
     name: "libf2fs_ioutils_host",
+    defaults: ["system-extras-cflags-defaults"],
 
     srcs: ["f2fs_ioutils.c"],
 
@@ -34,8 +34,6 @@ cc_library_host_static {
         "external/f2fs-tools/mkfs",
     ],
 
-    cflags: ["-Wno-unused-parameter"],
-
     static_libs: [
         "libselinux",
         "libsparse",
@@ -52,6 +50,7 @@ cc_library_host_static {
 
 cc_library_host_static {
     name: "libf2fs_dlutils_host",
+    defaults: ["system-extras-cflags-defaults"],
 
     srcs: ["f2fs_dlutils.c"],
 
@@ -71,6 +70,7 @@ cc_library_host_static {
 
 cc_library_shared {
     name: "libf2fs_dlutils",
+    defaults: ["system-extras-cflags-defaults"],
 
     srcs: ["f2fs_dlutils.c"],
 
@@ -90,6 +90,7 @@ cc_library_shared {
 
 cc_library_static {
     name: "libf2fs_dlutils_static",
+    defaults: ["system-extras-cflags-defaults"],
 
     srcs: ["f2fs_dlutils.c"],
 
@@ -109,6 +110,7 @@ cc_library_static {
 
 cc_library_static {
     name: "libf2fs_utils_static",
+    defaults: ["system-extras-cflags-defaults"],
 
     srcs: ["f2fs_utils.c"],
 
@@ -117,8 +119,6 @@ cc_library_static {
         "external/f2fs-tools/mkfs",
     ],
 
-    cflags: ["-Wno-unused-parameter"],
-
     static_libs: ["libsparse"],
 
     target: {
@@ -130,6 +130,7 @@ cc_library_static {
 
 cc_library_shared {
     name: "libf2fs_sparseblock",
+    defaults: ["system-extras-cflags-defaults"],
 
     srcs: ["f2fs_sparseblock.c"],
 
@@ -148,6 +149,7 @@ cc_library_shared {
 
 cc_binary {
     name: "f2fs_sparseblock",
+    defaults: ["system-extras-cflags-defaults"],
 
     srcs: ["f2fs_sparseblock.c"],