diff options
| author | Chih-Hung Hsieh <chh@google.com> | 2017-10-18 16:28:14 -0700 |
|---|---|---|
| committer | Chih-Hung Hsieh <chh@google.com> | 2017-10-20 15:46:36 -0700 |
| commit | 373d3c7257fa815d0b9ee8f16874470a6002042e (patch) | |
| tree | 2488faeb9a5a2dfd9f76054bd4ba001b4806ffb3 /kexec_tools | |
| parent | d7bf23ae7b93ec93b8b7c2ce98eaa2ea94f387aa (diff) | |
| download | extras-373d3c7257fa815d0b9ee8f16874470a6002042e.tar.gz | |
Use -Werror in system/extras
* Remove unused variables.
* Fix redefined macro warnings.
* Fix sign-compare warnings.
* Fix 'return false' in main().
* Keep existing warnings to fix later.
Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: Ib92ef5297693595fb84ed4f8e61665bda4cee312
Diffstat (limited to 'kexec_tools')
| -rw-r--r-- | kexec_tools/Android.mk | 1 | ||||
| -rw-r--r-- | kexec_tools/kexecload.c | 4 |
2 files changed, 2 insertions, 3 deletions
diff --git a/kexec_tools/Android.mk b/kexec_tools/Android.mk index f6bf7dc2..c8a49321 100644 --- a/kexec_tools/Android.mk +++ b/kexec_tools/Android.mk @@ -20,4 +20,5 @@ LOCAL_MODULE := kexecload LOCAL_MODULE_PATH := $(TARGET_OUT_OPTIONAL_EXECUTABLES) LOCAL_MODULE_TAGS := eng LOCAL_SRC_FILES := kexecload.c +LOCAL_CFLAGS := -Wall -Werror include $(BUILD_EXECUTABLE) diff --git a/kexec_tools/kexecload.c b/kexec_tools/kexecload.c index 2bf3d183..71365435 100644 --- a/kexec_tools/kexecload.c +++ b/kexec_tools/kexecload.c @@ -68,8 +68,7 @@ int main(int argc, char *argv[]) int atag_file, zimage_file; int atag_size, - zimage_size, - total_size; + zimage_size; void *atag_buffer; void *zimage_buffer; struct kexec_segment segment[2]; @@ -85,7 +84,6 @@ int main(int argc, char *argv[]) }; while (1) { - int option_index = 0; c = getopt_long(argc, argv, "s:th", longopts, NULL); if (c < 0) { break; |