summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
3 daysMerge "simpleperf: inject: Fix a segfault error when parsing vmlinux data" ↵HEADmastermainTreehugger Robot
into main
3 dayssimpleperf: inject: Fix a segfault error when parsing vmlinux dataYabin Cui
After change in aosp/3086621, addrs are changed when base_addr != 0. But they are still used to search in binary.range_count_map. This causes segfault error. Fix it by putting count values in the vector. Bug: 322399357 Test: run simpleperf_unit_test Test: run simpleperf manually Change-Id: I6f02f32288b870a4f758e1c8e28fec4b6e567467
5 daysMerge "simpleperf: inject: Ignore invalid data instead of aborting" into mainYabin Cui
5 dayssimpleperf: inject: Ignore invalid data instead of abortingYabin Cui
When converting ETM data for the kernel, the check "CHECK_GE(vaddr, first_load_segment_addr)" may fail. It happens when the ETM data asks the decoder to decode .word data at the end of functions as instructions. Not sure why this can happen (maybe because of garbage ETM data caused by overflow), but we don't need to abort in this situation. Instead, ignore the invalid data. Bug: 322399357 Test: run simpleperf_unit_test Change-Id: Id42a9d84b610bba9003d899efc8fd6ceb39542f9
6 daysMerge "profcollectd: Add kernel release in config" into mainYabin Cui
10 daysprofcollectd: Add kernel release in configYabin Cui
It makes us easier to locate kernel prebuilts in the build server. Bug: 323054107 Test: run profcollectd Change-Id: I3f42ca89e76335b16397b57fdc616d4096c78fea
11 daysMerge "Replace impl ToString with impl Display" into mainTreehugger Robot
11 daysReplace impl ToString with impl DisplayChris Wailes
If the Display interface is implemented the compiler will automatically derive an implementation of ToString. Test: m rust Bug: 333887339 Change-Id: Ib07011b5004bdc42b60eff7405528b72e77b9496
12 daysMerge "simpleperf: Fix default value for --etm-flush-interval" into mainYabin Cui
12 dayssimpleperf: Fix default value for --etm-flush-intervalYabin Cui
options.PullUintValue() returns true even when --etm-flush-interval isn't used. In this case, interval is still set to etm_flush_interval_, which makes it 0. Bug: 336375740 Test: run simpleperf manually Change-Id: I95fafcf24b9ae821d8b19782813c7b2f312bf317
12 daysMerge "simpleperf: record: Add --etm-flush-interval" into mainYabin Cui
12 dayssimpleperf: record: Add --etm-flush-intervalYabin Cui
Add --etm-flush-interval to adjust the interval between ETM data flushes. So we can use smaller interval when needed. Bug: 336375740 Test: run simpleperf_unit_test Change-Id: I1e6805446fa08ee85e9b4033ff827709c34ae530
12 daysMerge changes Ib892aeea,I1b5f2b85,I449517fb,I6583aebc into mainYabin Cui
* changes: simpleperf: Delay processing ETM data until the buffer is half full simpleperf: Rotate the last cpu disabling ETM events simpleperf: Flush ETM data at the end of recording simpleperf: Enable ETM events after create aux buffer
12 dayssimpleperf: Delay processing ETM data until the buffer is half fullYabin Cui
When using --decode-etm, the main thread is busy processing ETM data and can miss flushing ETM data. To fix this, we can delay processing ETM data after recording. This patch triggers ETM data processing when the buffer is at least half full. In the default configuration, the buffer is large enough to hold ETM data for several seconds. So effectively, this delays processing ETM data after recording. Bug: 336375740 Test: run simpleperf_unit_test Change-Id: Ib892aeea402773b1cab785f2c14886bb9f96d851
12 dayssimpleperf: Rotate the last cpu disabling ETM eventsYabin Cui
When using ETR, ETM data is flushed to the aux buffer of the last cpu disabling ETM events. To avoid overflowing the aux buffer for one cpu, rotate the last cpu disabling ETM events. Bug: 336375740 Test: run simpleperf manually Change-Id: I1b5f2b85935513a3485d84fe0b850b8223ad03b4
12 dayssimpleperf: Flush ETM data at the end of recordingYabin Cui
So we can get the last ETM data generated during recording. Bug: 336375740 Test: run simpleperf manually Change-Id: I449517fb959e4f8310cd1fc582e2182552d0353d
13 dayssimpleperf: Enable ETM events after create aux bufferYabin Cui
Otherwise, ETM events can't be enabled successfully. Bug: 336375740 Test: run simpleperf manually Change-Id: I6583aebced57d739f98769cc39dab862569ec8ad
13 daysMerge "tools/check_elf_alignment.sh: Use double quotes" into mainTreehugger Robot
2024-05-06tools/check_elf_alignment.sh: Use double quotesWill McVicker
When files have spaces in them, we need to use double quotes. Otherwise some of the bash commands like `basename` and `mktemp` don't use the full filename which results in incorrect behavior. Bug: 337895632 Change-Id: Ia50946051bd8ef6cff460810d3559f98d55731c6 Signed-off-by: Will McVicker <willmcvicker@google.com>
2024-05-03Merge "Automatically delete trace files after generating report" into mainTreehugger Robot
2024-05-03Merge "check_elf: dump all libs" into mainTreehugger Robot
2024-05-02check_elf: dump all libsSteven Moreland
Tripped me up in b/337956762#comment7, where I thought this binary had no native libs, but it was really 32-bit only. Bug: 337956762 Test: manual Change-Id: I225757e2fd5618aa058ef1a528850827feb309f1
2024-05-01Merge "tools/check_elf_alignment.sh: Add zip alignment check" into mainTreehugger Robot
2024-05-01Automatically delete trace files after generating reportAbhishek Gadewar
Summary: After switching to a time-based approach for report generation, we want to ensure that we don't accidentally include repeated trace files. Thus, after creating a zip file for the report, we delete the originals. Test: Ran adb shell device_config put profcollect_native_boot enabled true and rebooted the device to enable profcollectd. Ranprofcollectctl once to collect trace files, profcollectctl process to process them, and then profcollectctl report to generate the report. Verified that the processed trace files were removed after profcollectctl report was run & that the config.json file remained. Tags: Change-Id: Ic6ab934f52c7af277817ce992faebd96fcde223f Signed-off-by: Abhishek Gadewar <abhishekgadewar@meta.com>
2024-04-30tools/check_elf_alignment.sh: Add zip alignment checkWill McVicker
If an APK is passed in, then check the zipalignment as well to see if it's 16K aligned. This will help cover both requirements -- zipalignment and ELF alignment. Also, add a print message after checking ELF alignment to indicate that it was successful. This helps indicate success when there are no shared libraries in the APK. Bug: 337895632 Change-Id: I2578dba77e13570aa5b880f950058cfcd939857f
2024-04-30Merge "simpleperf: Update collect_etm_data_for_autofdo.md" into mainYabin Cui
2024-04-30simpleperf: Update collect_etm_data_for_autofdo.mdYabin Cui
Update the document to align with recent changes in AutoFDO on GitHub and the method for adding profiles to toolchain/pgo-profiles. Bug: 337338041 Test: none Change-Id: Ic03b512eadf9b31a77ee564c0167451d44ce814f
2024-04-29Merge "tools: Add script to check ELF alignment" into mainSteven Moreland
2024-04-29tools: Add script to check ELF alignmentWill McVicker
This script can be used to check the ELF alignment of shared libraries in the provided path or in the provided *.apk file. Bug: 337895632 Change-Id: I3b40383eab076809a73e2ffcf920e6bd8b638cff
2024-04-23Merge "lpdump: Add info about super partition" into mainSandeep Dhavale
2024-04-22lpdump: Add info about super partitionSandeep Dhavale
Currently we do not print info about super partition in lpdump. Let's add it so we can get to know super's size and used size. Available space can be inferred from these two. Bug: 335891825 Test: lpdump --json Test: atest CtsEdiHostTestCases Change-Id: Ic3dea6346492c1f94c6432a96c55bfc6164d1b89 Signed-off-by: Sandeep Dhavale <dhavale@google.com>
2024-04-19Merge changes from topic "am-70381af1ffc5488eae2b942658dfabd3" into mainAutomerger Merge Worker
* changes: Merge changes from topic "am-4212e85279cd4af49081bfd97be33764" into android14-tests-dev am: 6df0a78dd6 -s ours [automerger skipped] Merge "Merge "Merge "simpleperf: Fix flaky test check_trampoline_after_art_jni_methods" into android12-tests-dev am: e4cc9c7725" into android12L-tests-dev am: 6b5a8b2336" into android13-tests-dev am: 57b29e5ba9 -s ours am: 04d7e66ade -s ours
2024-04-19Merge changes from topic "am-4212e85279cd4af49081bfd97be33764" into ↵Automerger Merge Worker
android14-tests-dev am: 6df0a78dd6 -s ours am skip reason: Merged-In I846cd2bbf1159abf05e9d754c2e96c12912c7d72 with SHA-1 31ec381052 is already in history Original change: https://android-review.googlesource.com/c/platform/system/extras/+/3049053 Change-Id: I0d5ac89b02a494ffc61043c67db5094f2d1d15ca Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-19[automerger skipped] Merge "Merge "Merge "simpleperf: Fix flaky test ↵Automerger Merge Worker
check_trampoline_after_art_jni_methods" into android12-tests-dev am: e4cc9c7725" into android12L-tests-dev am: 6b5a8b2336" into android13-tests-dev am: 57b29e5ba9 -s ours am: 04d7e66ade -s ours am skip reason: Merged-In I846cd2bbf1159abf05e9d754c2e96c12912c7d72 with SHA-1 31ec381052 is already in history Original change: https://android-review.googlesource.com/c/platform/system/extras/+/3049053 Change-Id: Ieefaaeceb1f3686c899492f2531aa4ac82260eef Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-19Merge changes from topic "am-e9cc26aa52074db0a6d764cfe3878879" into mainAutomerger Merge Worker
* changes: Merge changes from topic "am-58ca7d8a2c394672818c16262cc7b67b" into android14-tests-dev am: 8961961b84 -s ours [automerger skipped] Merge "Merge "Merge "simpleperf: Fix record_cmd#check_trampoline test" into android12-tests-dev am: 927e0ca800" into android12L-tests-dev am: d9fb8dd703" into android13-tests-dev am: bc87a068b5 -s ours am: 39f3b7a553 -s ours
2024-04-19Merge changes from topic "am-58ca7d8a2c394672818c16262cc7b67b" into ↵Automerger Merge Worker
android14-tests-dev am: 8961961b84 -s ours am skip reason: Merged-In I401b091e27e7b3ae86f003a270b53be4060c922f with SHA-1 b347fdbef6 is already in history Original change: https://android-review.googlesource.com/c/platform/system/extras/+/3049052 Change-Id: Ifbe2c5d65e94cc97d7e455dfa2e67eac1253ddc4 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-19[automerger skipped] Merge "Merge "Merge "simpleperf: Fix ↵Automerger Merge Worker
record_cmd#check_trampoline test" into android12-tests-dev am: 927e0ca800" into android12L-tests-dev am: d9fb8dd703" into android13-tests-dev am: bc87a068b5 -s ours am: 39f3b7a553 -s ours am skip reason: Merged-In I401b091e27e7b3ae86f003a270b53be4060c922f with SHA-1 b347fdbef6 is already in history Original change: https://android-review.googlesource.com/c/platform/system/extras/+/3049052 Change-Id: Icef8a8907710c2c45ed78df89ee02cc6398c7898 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-19Merge changes from topic "am-4212e85279cd4af49081bfd97be33764" into ↵android14-tests-devAutomerger Merge Worker
android14-tests-dev * changes: [automerger skipped] Merge "Merge "Merge "simpleperf: Fix flaky test check_trampoline_after_art_jni_methods" into android12-tests-dev am: e4cc9c7725" into android12L-tests-dev am: 6b5a8b2336" into android13-tests-dev am: 57b29e5ba9 -s ours [automerger skipped] Merge "Merge "simpleperf: Fix flaky test check_trampoline_after_art_jni_methods" into android12-tests-dev am: e4cc9c7725" into android12L-tests-dev am: 6b5a8b2336 am: 5cec5340a8 -s ours
2024-04-19[automerger skipped] Merge "Merge "Merge "simpleperf: Fix flaky test ↵Automerger Merge Worker
check_trampoline_after_art_jni_methods" into android12-tests-dev am: e4cc9c7725" into android12L-tests-dev am: 6b5a8b2336" into android13-tests-dev am: 57b29e5ba9 -s ours am skip reason: Merged-In I846cd2bbf1159abf05e9d754c2e96c12912c7d72 with SHA-1 31ec381052 is already in history Original change: https://android-review.googlesource.com/c/platform/system/extras/+/3049053 Change-Id: Ifc0f8273a783c81844e26593a7435c7f0a5d9b9e Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-19[automerger skipped] Merge "Merge "simpleperf: Fix flaky test ↵Automerger Merge Worker
check_trampoline_after_art_jni_methods" into android12-tests-dev am: e4cc9c7725" into android12L-tests-dev am: 6b5a8b2336 am: 5cec5340a8 -s ours am skip reason: Merged-In I846cd2bbf1159abf05e9d754c2e96c12912c7d72 with SHA-1 31ec381052 is already in history Original change: https://android-review.googlesource.com/c/platform/system/extras/+/3049053 Change-Id: Ie838d9cb80a7d6bc45e6b47d92be3b71f1b23b26 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-19Merge changes from topic "am-58ca7d8a2c394672818c16262cc7b67b" into ↵Automerger Merge Worker
android14-tests-dev * changes: [automerger skipped] Merge "Merge "Merge "simpleperf: Fix record_cmd#check_trampoline test" into android12-tests-dev am: 927e0ca800" into android12L-tests-dev am: d9fb8dd703" into android13-tests-dev am: bc87a068b5 -s ours [automerger skipped] Merge "Merge "simpleperf: Fix record_cmd#check_trampoline test" into android12-tests-dev am: 927e0ca800" into android12L-tests-dev am: d9fb8dd703 am: 0498708589 -s ours
2024-04-19[automerger skipped] Merge "Merge "Merge "simpleperf: Fix ↵Automerger Merge Worker
record_cmd#check_trampoline test" into android12-tests-dev am: 927e0ca800" into android12L-tests-dev am: d9fb8dd703" into android13-tests-dev am: bc87a068b5 -s ours am skip reason: Merged-In I401b091e27e7b3ae86f003a270b53be4060c922f with SHA-1 b347fdbef6 is already in history Original change: https://android-review.googlesource.com/c/platform/system/extras/+/3049052 Change-Id: Ie0ed4de209fb78e6eb44039e1451b1d7fca238b1 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-19[automerger skipped] Merge "Merge "simpleperf: Fix ↵Automerger Merge Worker
record_cmd#check_trampoline test" into android12-tests-dev am: 927e0ca800" into android12L-tests-dev am: d9fb8dd703 am: 0498708589 -s ours am skip reason: Merged-In I401b091e27e7b3ae86f003a270b53be4060c922f with SHA-1 b347fdbef6 is already in history Original change: https://android-review.googlesource.com/c/platform/system/extras/+/3049052 Change-Id: I7dff312bee50058b2a8aa42f61164de18b28c360 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-19Merge "Merge "Merge "simpleperf: Fix flaky test ↵android13-tests-devAutomerger Merge Worker
check_trampoline_after_art_jni_methods" into android12-tests-dev am: e4cc9c7725" into android12L-tests-dev am: 6b5a8b2336" into android13-tests-dev
2024-04-19Merge "Merge "simpleperf: Fix flaky test ↵Automerger Merge Worker
check_trampoline_after_art_jni_methods" into android12-tests-dev am: e4cc9c7725" into android12L-tests-dev am: 6b5a8b2336 Original change: https://android-review.googlesource.com/c/platform/system/extras/+/3049053 Change-Id: Ia476005ba9cc0e7a529f965696c7ee49ae8dff58 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-19Merge "Merge "Merge "simpleperf: Fix record_cmd#check_trampoline test" into ↵Automerger Merge Worker
android12-tests-dev am: 927e0ca800" into android12L-tests-dev am: d9fb8dd703" into android13-tests-dev
2024-04-19Merge "Merge "simpleperf: Fix record_cmd#check_trampoline test" into ↵Automerger Merge Worker
android12-tests-dev am: 927e0ca800" into android12L-tests-dev am: d9fb8dd703 Original change: https://android-review.googlesource.com/c/platform/system/extras/+/3049052 Change-Id: Ieaab6a03bcc4c5da5cbcd85365dda2427c3fd50f Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-19Merge "Merge "simpleperf: Fix flaky test ↵android12L-tests-devAutomerger Merge Worker
check_trampoline_after_art_jni_methods" into android12-tests-dev am: e4cc9c7725" into android12L-tests-dev
2024-04-19Merge "simpleperf: Fix flaky test check_trampoline_after_art_jni_methods" ↵Treehugger Robot
into android12-tests-dev am: e4cc9c7725 Original change: https://android-review.googlesource.com/c/platform/system/extras/+/3049053 Change-Id: I33ed7fa5e08bc1cf07e8478c8ecfe82fd11e9ee5 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-04-19Merge "Merge "simpleperf: Fix record_cmd#check_trampoline test" into ↵Automerger Merge Worker
android12-tests-dev am: 927e0ca800" into android12L-tests-dev
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-20 17:47:53 +0000